From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF76C6FA82 for ; Sat, 10 Sep 2022 21:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231256AbiIJV0u (ORCPT ); Sat, 10 Sep 2022 17:26:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231156AbiIJVYt (ORCPT ); Sat, 10 Sep 2022 17:24:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FD8C501A8; Sat, 10 Sep 2022 14:20:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4D2A5B80957; Sat, 10 Sep 2022 21:19:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 551B6C43142; Sat, 10 Sep 2022 21:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662844775; bh=tSXfzAbEEGzejCMYQW03tijt0WD8X9cB7zVT+7xfYmY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WujG9K1twcLk4MGo5BMTs17r+yvt55tHMaxKSUrKe82qOamPLKfO2h2qbGfl0np0o 72uGJAp7np+HpnE+lwdg9JH9gffJGJjRaqlTsbLkT6/UBXuCdzZ53xRUxmfYj1sMfx 9FbTLVmxRQPpTo6cFt2Gie83fpYwyY1EdpVN9XTcHVoVSOXzQ+IwTuACd8E9E7ZTMb Rsrs162r6L7axXko/PscbyB9fPSDjuspnOPwtJYKNAhyfj5yS9+oXf1qnA1eHGDvUm y1Nv8rQkWlLP5ympVj6lWMbUjJ9VDQef3kRSYWxS8GE/pQoPM02a3EvtDcBNZq+lX+ ZpUrKCSLkT7Hw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yu Zhe , Will Deacon , Sasha Levin , mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 6/8] perf/arm_pmu_platform: fix tests for platform_get_irq() failure Date: Sat, 10 Sep 2022 17:19:19 -0400 Message-Id: <20220910211921.70891-6-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220910211921.70891-1-sashal@kernel.org> References: <20220910211921.70891-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yu Zhe [ Upstream commit 6bb0d64c100091e131cd16710b62fda3319cd0af ] The platform_get_irq() returns negative error codes. It can't actually return zero. Signed-off-by: Yu Zhe Link: https://lore.kernel.org/r/20220825011844.8536-1-yuzhe@nfschina.com Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- drivers/perf/arm_pmu_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c index 199293450acfc..0ffa4f45a8391 100644 --- a/drivers/perf/arm_pmu_platform.c +++ b/drivers/perf/arm_pmu_platform.c @@ -118,7 +118,7 @@ static int pmu_parse_irqs(struct arm_pmu *pmu) if (num_irqs == 1) { int irq = platform_get_irq(pdev, 0); - if (irq && irq_is_percpu_devid(irq)) + if ((irq > 0) && irq_is_percpu_devid(irq)) return pmu_parse_percpu_irq(pmu, irq); } -- 2.35.1