From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Li Zhong <floridsleeves@gmail.com>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org, song@kernel.org,
Li Zhong <floridsleeves@gmail.com>
Subject: Re: [PATCH v1] drivers/md/md-bitmap: check the return value of md_bitmap_get_counter()
Date: Tue, 13 Sep 2022 12:11:56 +0300 [thread overview]
Message-ID: <202209111048.YGgWVmUV-lkp@intel.com> (raw)
In-Reply-To: <20220909040936.2610780-1-floridsleeves@gmail.com>
Hi Li,
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Li-Zhong/drivers-md-md-bitmap-check-the-return-value-of-md_bitmap_get_counter/20220909-121143
base: git://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-next
config: m68k-randconfig-m031-20220909
compiler: m68k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/md/md-bitmap.c:2211 md_bitmap_resize() error: we previously assumed 'bmc_new' could be null (see line 2198)
vim +/bmc_new +2211 drivers/md/md-bitmap.c
c9d65032282943 drivers/md/bitmap.c Guoqing Jiang 2016-05-02 2184 } else
c9d65032282943 drivers/md/bitmap.c Guoqing Jiang 2016-05-02 2185 bitmap->counts.bp[page].count += 1;
c9d65032282943 drivers/md/bitmap.c Guoqing Jiang 2016-05-02 2186 }
c9d65032282943 drivers/md/bitmap.c Guoqing Jiang 2016-05-02 2187 }
c9d65032282943 drivers/md/bitmap.c Guoqing Jiang 2016-05-02 2188
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2189 for (block = 0; block < blocks; ) {
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2190 bitmap_counter_t *bmc_old, *bmc_new;
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2191 int set;
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2192
e64e4018d57271 drivers/md/md-bitmap.c Andy Shevchenko 2018-08-01 2193 bmc_old = md_bitmap_get_counter(&old_counts, block, &old_blocks, 0);
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2194 set = bmc_old && NEEDED(*bmc_old);
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2195
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2196 if (set) {
e64e4018d57271 drivers/md/md-bitmap.c Andy Shevchenko 2018-08-01 2197 bmc_new = md_bitmap_get_counter(&bitmap->counts, block, &new_blocks, 1);
a0b3a521efba6a drivers/md/md-bitmap.c Li Zhong 2022-09-08 @2198 if (bmc_new && *bmc_new == 0) {
^^^^^^^
New check for NULL
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2199 /* need to set on-disk bits too. */
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2200 sector_t end = block + new_blocks;
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2201 sector_t start = block >> chunkshift;
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2202 start <<= chunkshift;
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2203 while (start < end) {
e64e4018d57271 drivers/md/md-bitmap.c Andy Shevchenko 2018-08-01 2204 md_bitmap_file_set_bit(bitmap, block);
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2205 start += 1 << chunkshift;
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2206 }
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2207 *bmc_new = 2;
e64e4018d57271 drivers/md/md-bitmap.c Andy Shevchenko 2018-08-01 2208 md_bitmap_count_page(&bitmap->counts, block, 1);
e64e4018d57271 drivers/md/md-bitmap.c Andy Shevchenko 2018-08-01 2209 md_bitmap_set_pending(&bitmap->counts, block);
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2210 }
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 @2211 *bmc_new |= NEEDED_MASK;
^^^^^^^^
Unchecked dereference
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2212 if (new_blocks < old_blocks)
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2213 old_blocks = new_blocks;
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2214 }
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2215 block += old_blocks;
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2216 }
d60b479d177a57 drivers/md/bitmap.c NeilBrown 2012-05-22 2217
0868b99c214a3d drivers/md/md-bitmap.c Zdenek Kabelac 2017-11-08 2218 if (bitmap->counts.bp != old_counts.bp) {
next prev parent reply other threads:[~2022-09-13 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 4:09 Li Zhong
2022-09-13 9:11 ` Dan Carpenter [this message]
2022-10-20 17:47 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209111048.YGgWVmUV-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=floridsleeves@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=lkp@intel.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®