From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: cgel.zte@gmail.com
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
Cspeakup@linux-speakup.org, linux-kernel@vger.kernel.org,
Xu Panda <xu.panda@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] speakup/utils: use "!P" instead of "P == 0"
Date: Mon, 12 Sep 2022 13:02:58 +0200 [thread overview]
Message-ID: <20220912110258.jwyv4xenfdvmo3p3@begin> (raw)
In-Reply-To: <20220912102059.18215-1-xu.panda@zte.com.cn>
cgel.zte@gmail.com, le lun. 12 sept. 2022 10:21:00 +0000, a ecrit:
> From: Xu Panda <xu.panda@zte.com.cn>
>
> comparing pointer to 0, use !P instead of it.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..58ca9847637f 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
> else
> snprintf(filename, sizeof(filename), "%s", name);
> infile = fopen(filename, "r");
> - if (infile == 0) {
> + if (!infile) {
> fprintf(stderr, "can't open %s\n", filename);
> exit(1);
> }
> --
> 2.15.2
>
prev parent reply other threads:[~2022-09-12 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 10:21 cgel.zte
2022-09-12 11:02 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912110258.jwyv4xenfdvmo3p3@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=Cspeakup@linux-speakup.org \
--cc=cgel.zte@gmail.com \
--cc=chris@the-brannons.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=w.d.hubbs@gmail.com \
--cc=xu.panda@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®