From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78409ECAAD8 for ; Tue, 13 Sep 2022 16:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbiIMQyB (ORCPT ); Tue, 13 Sep 2022 12:54:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230249AbiIMQxf (ORCPT ); Tue, 13 Sep 2022 12:53:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7DB6419B9; Tue, 13 Sep 2022 08:46:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4100DB80F00; Tue, 13 Sep 2022 14:40:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0417C433B5; Tue, 13 Sep 2022 14:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663080050; bh=HyzFvV/ai3qVeVlc4NIL38TdfZeCLo45wfqTqYKrY8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mh6qI5NIG9vc5398YfHNRC2o5MXdDMcUGG92/ROmuu7UG23FV82AsQCiPxHL7zmiB Hr5gJg7kUHEheAif+QfcBX6SDdXV/VY6UdZg1yApSWhkehfM4w9NR96zC9qan528Ms oTpP8rvWt1s86G9WN7chzZAAkFFCFPpasWPdVPU89ffJ8Dlzmgz6jwLJjvoseowQZp ttlBJrgIzURJUMzsSl0VgRIORsfWe2bIApN6Zwc3RRfHwUU+aWmI+jCzm0mH/b6h51 qqE9cywt1BzrztNQf0oNHKh5aqst1AVfI/Qs+o47G7yfSrKAPAae/ROonmAcZp6YgY 8xctbP/iqQOIQ== Date: Tue, 13 Sep 2022 09:40:47 -0500 From: Bjorn Andersson To: Judy Hsiao Cc: Bjorn Andersson , Andy Gross , Rob Herring , Srini Kandagatla , dianders@chromium.org, mka@chromium.org, cychiang@google.com, judyhsiao@google.com, swboyd@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivasa Rao Mandadapu Subject: Re: [PATCH v4] arm64: dts: qcom: sc7280: Fix Dmic no sound on villager-r1 Message-ID: <20220913144047.bdeow6lgegcunl2r@builder.lan> References: <20220826065621.2255795-1-judyhsiao@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220826065621.2255795-1-judyhsiao@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 06:56:21AM +0000, Judy Hsiao wrote: > Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the > DMIC power source to match the hardware schematic. > > This patch: > 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator. > 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply > setting. > > Co-developed-by: Srinivasa Rao Mandadapu > Signed-off-by: Srinivasa Rao Mandadapu > Signed-off-by: Judy Hsiao > --- > Changes since V3: > -- Update the commit message and fix extra blank line. > Changes since V2: > -- Update the commit message. > Changes since V1: > -- Update the commit message. > > This patch depends on: > arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1] > > [1] https://patchwork.kernel.org/patch/12929106 With [1] applied this patch applies cleanly, but it doesn't built. What am I missing? Regards, Bjorn > > .../dts/qcom/sc7280-herobrine-villager-r1.dts | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > index c03b3ae4de50..fd202a8f6a33 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > @@ -12,3 +12,30 @@ / { > model = "Google Villager (rev1+)"; > compatible = "google,villager", "qcom,sc7280"; > }; > + > +&lpass_va_macro { > + vdd-micb-supply = <&pp1800_l2c>; > +}; > + > +&sound { > + audio-routing = > + "IN1_HPHL", "HPHL_OUT", > + "IN2_HPHR", "HPHR_OUT", > + "AMIC1", "MIC BIAS1", > + "AMIC2", "MIC BIAS2", > + "VA DMIC0", "vdd-micb", > + "VA DMIC1", "vdd-micb", > + "VA DMIC2", "vdd-micb", > + "VA DMIC3", "vdd-micb", > + "TX SWR_ADC0", "ADC1_OUTPUT", > + "TX SWR_ADC1", "ADC2_OUTPUT", > + "TX SWR_ADC2", "ADC3_OUTPUT", > + "TX SWR_DMIC0", "DMIC1_OUTPUT", > + "TX SWR_DMIC1", "DMIC2_OUTPUT", > + "TX SWR_DMIC2", "DMIC3_OUTPUT", > + "TX SWR_DMIC3", "DMIC4_OUTPUT", > + "TX SWR_DMIC4", "DMIC5_OUTPUT", > + "TX SWR_DMIC5", "DMIC6_OUTPUT", > + "TX SWR_DMIC6", "DMIC7_OUTPUT", > + "TX SWR_DMIC7", "DMIC8_OUTPUT"; > +}; > -- > 2.37.2.672.g94769d06f0-goog >