From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F21DCECAAD3 for ; Wed, 14 Sep 2022 09:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231276AbiINJHT (ORCPT ); Wed, 14 Sep 2022 05:07:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230363AbiINJGV (ORCPT ); Wed, 14 Sep 2022 05:06:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DDAE760F5; Wed, 14 Sep 2022 02:03:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C03561998; Wed, 14 Sep 2022 09:03:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96D0EC43470; Wed, 14 Sep 2022 09:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663146205; bh=veIuWdajrcEzBTqa9/+StGfFu9s7ZQPG70dnX2gD020=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aHHPk9MmUqAS/PiZLM5vJqgSODmNJHQvYI6/uBShr3mN1H3ESHdx8sh2gPqE3tGsu 87q+dF6wzEZO2A1J+6Zf1/OHNStqoVVSytmExItxO9Bn1qE5uEz48Dii9R21GuMnBr Tb8OfFA/bcy8W57V3wdYz3fTNXOG3+txYsoW7L8o6+UrMjgYoKmNwV091EhkCqyizF OnSdj/H1XazILleKvXErivLa+B3S18OhAdTyT3fhQ7M/dHF/5EIQit4t/idpi25j8+ xK9nQFO9LcaWl7SQLb9jL1mJ04KK+0ezVZXtZ837iK0OC4ABP1C0VhEs1Le9EN7ezX dOgpNc4+VuBWg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xiaolei Wang , Mark Brown , Sasha Levin , lgirdwood@gmail.com Subject: [PATCH AUTOSEL 5.10 02/13] regulator: pfuze100: Fix the global-out-of-bounds access in pfuze100_regulator_probe() Date: Wed, 14 Sep 2022 05:03:04 -0400 Message-Id: <20220914090317.471116-2-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220914090317.471116-1-sashal@kernel.org> References: <20220914090317.471116-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiaolei Wang [ Upstream commit 78e1e867f44e6bdc72c0e6a2609a3407642fb30b ] The pfuze_chip::regulator_descs is an array of size PFUZE100_MAX_REGULATOR, the pfuze_chip::pfuze_regulators is the pointer to the real regulators of a specific device. The number of real regulator is supposed to be less than the PFUZE100_MAX_REGULATOR, so we should use the size of 'regulator_num * sizeof(struct pfuze_regulator)' in memcpy(). This fixes the out of bounds access bug reported by KASAN. Signed-off-by: Xiaolei Wang Link: https://lore.kernel.org/r/20220825111922.1368055-1-xiaolei.wang@windriver.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/pfuze100-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c index 0a19500d3725e..44a8e500fb304 100644 --- a/drivers/regulator/pfuze100-regulator.c +++ b/drivers/regulator/pfuze100-regulator.c @@ -791,7 +791,7 @@ static int pfuze100_regulator_probe(struct i2c_client *client, ((pfuze_chip->chip_id == PFUZE3000) ? "3000" : "3001")))); memcpy(pfuze_chip->regulator_descs, pfuze_chip->pfuze_regulators, - sizeof(pfuze_chip->regulator_descs)); + regulator_num * sizeof(struct pfuze_regulator)); ret = pfuze_parse_regulators_dt(pfuze_chip); if (ret) -- 2.35.1