From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C602FECAAD3 for ; Wed, 14 Sep 2022 09:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231175AbiINJNG (ORCPT ); Wed, 14 Sep 2022 05:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231473AbiINJMY (ORCPT ); Wed, 14 Sep 2022 05:12:24 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9795B7AC24; Wed, 14 Sep 2022 02:05:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 162E0CE139A; Wed, 14 Sep 2022 09:05:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0B20C433D6; Wed, 14 Sep 2022 09:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663146320; bh=HF4PGP0+xNYDtxf78yui0Q9OzSck6OrFjMcyX6mBa7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K9sQNEfGghfQLSBV7Fsop71w8D7LIRXkMDkJMijhVfiC73Cup9d4Pyjy/Rh/aQEcD NEqlREpaB1OFkNRorpQgXfe7WOZv0U6o0Oa1VX2PkuSNKig60WAiPDsYkohUGfjh3j glWphUNE/Wr+P9ksMe2cGEtAbWtAX0BJZPqkZSAfxhormsABwZIYZPfyGJBmHvy+uB 1MiQRkcosuRcPi1uBTRgPJv2qbZ2giz8/LgG0EPxG7vsUdll7aV2kKp7DZOmynNv03 Yh0FewCrlGTSiUBkIkO/pvTrJBOoyqzisO2iRRha3C/kdNf2JJrBtolz2yp2+1+cuD sOtiD8zofDGCQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xiaolei Wang , Mark Brown , Sasha Levin , lgirdwood@gmail.com Subject: [PATCH AUTOSEL 4.14 2/8] regulator: pfuze100: Fix the global-out-of-bounds access in pfuze100_regulator_probe() Date: Wed, 14 Sep 2022 05:05:06 -0400 Message-Id: <20220914090514.471614-2-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220914090514.471614-1-sashal@kernel.org> References: <20220914090514.471614-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiaolei Wang [ Upstream commit 78e1e867f44e6bdc72c0e6a2609a3407642fb30b ] The pfuze_chip::regulator_descs is an array of size PFUZE100_MAX_REGULATOR, the pfuze_chip::pfuze_regulators is the pointer to the real regulators of a specific device. The number of real regulator is supposed to be less than the PFUZE100_MAX_REGULATOR, so we should use the size of 'regulator_num * sizeof(struct pfuze_regulator)' in memcpy(). This fixes the out of bounds access bug reported by KASAN. Signed-off-by: Xiaolei Wang Link: https://lore.kernel.org/r/20220825111922.1368055-1-xiaolei.wang@windriver.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/pfuze100-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c index 587a6bf9037b7..6b9c29d6825d4 100644 --- a/drivers/regulator/pfuze100-regulator.c +++ b/drivers/regulator/pfuze100-regulator.c @@ -614,7 +614,7 @@ static int pfuze100_regulator_probe(struct i2c_client *client, ((pfuze_chip->chip_id == PFUZE200) ? "200" : "3000")); memcpy(pfuze_chip->regulator_descs, pfuze_chip->pfuze_regulators, - sizeof(pfuze_chip->regulator_descs)); + regulator_num * sizeof(struct pfuze_regulator)); ret = pfuze_parse_regulators_dt(pfuze_chip); if (ret) -- 2.35.1