From: Arvind Yadav <Arvind.Yadav@amd.com>
To: <Christian.Koenig@amd.com>, <andrey.grodzovsky@amd.com>,
<shashank.sharma@amd.com>, <amaranath.somalapuram@amd.com>,
<Arunpravin.PaneerSelvam@amd.com>, <sumit.semwal@linaro.org>,
<gustavo@padovan.org>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-kernel@vger.kernel.org>
Cc: "Arvind Yadav" <Arvind.Yadav@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: [PATCH v4 2/6] dma-buf: set signaling bit for the stub fence
Date: Wed, 14 Sep 2022 22:13:17 +0530 [thread overview]
Message-ID: <20220914164321.2156-3-Arvind.Yadav@amd.com> (raw)
In-Reply-To: <20220914164321.2156-1-Arvind.Yadav@amd.com>
Here's setting software signaling bit for the stub fence
which is always signaled. If this fence signaling bit is
not set then the AMD GPU scheduler will cause a GPU reset
due to a GPU scheduler cleanup activity timeout.
Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
Changes in v1 :
1- Addressing Christian's comment to remove unnecessary callback.
2- Replacing CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS.
3- The version of this patch is also changed and previously
it was [PATCH 3/4]
Changes in v2 :
1 - perviously using __dma_fence_enable_signaling() for enable
signaling.
2 - #ifdef CONFIG_DEBUG_WW_MUTEX_SLOWPATH removed
Changes in v3 :
1 - Enable Signaling bit for dma_fence_allocate_private_stub.
---
drivers/dma-buf/dma-fence.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index 64c99739ad23..645c158b7e01 100644
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -136,6 +136,10 @@ struct dma_fence *dma_fence_get_stub(void)
&dma_fence_stub_ops,
&dma_fence_stub_lock,
0, 0);
+
+ set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
+ &dma_fence_stub.flags);
+
dma_fence_signal_locked(&dma_fence_stub);
}
spin_unlock(&dma_fence_stub_lock);
@@ -161,6 +165,10 @@ struct dma_fence *dma_fence_allocate_private_stub(void)
&dma_fence_stub_ops,
&dma_fence_stub_lock,
0, 0);
+
+ set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
+ &dma_fence_stub.flags);
+
dma_fence_signal(fence);
return fence;
--
2.25.1
next prev parent reply other threads:[~2022-09-14 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 16:43 [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on debug Arvind Yadav
2022-09-14 16:43 ` [PATCH v4 1/6] dma-buf: Remove the signaled bit status check Arvind Yadav
2022-09-14 16:43 ` Arvind Yadav [this message]
2022-09-14 16:43 ` [PATCH v4 3/6] dma-buf: Enable signaling on fence for selftests Arvind Yadav
2022-09-14 16:43 ` [PATCH v4 4/6] dma-buf: dma_fence_wait must enable signaling Arvind Yadav
2022-09-15 12:06 ` Christian König
2022-09-14 16:43 ` [PATCH v4 5/6] drm/sched: Use parent fence instead of finished Arvind Yadav
2022-09-29 14:53 ` Steven Price
2022-09-29 14:57 ` Christian König
2022-09-29 15:31 ` Steven Price
2022-09-29 17:07 ` [Linaro-mm-sig] " Christian König
2022-09-14 16:43 ` [PATCH v4 6/6] dma-buf: Check status of enable-signaling bit on debug Arvind Yadav
2022-09-15 12:06 ` Christian König
2022-09-15 12:07 ` [PATCH v4 0/6] " Christian König
2022-09-15 13:02 ` Yadav, Arvind
2022-09-15 16:05 ` Christian König
2022-09-17 6:17 ` Ville Syrjälä
2022-09-17 15:18 ` [Linaro-mm-sig] " Christian König
2022-09-19 11:26 ` Ville Syrjälä
2022-09-19 11:38 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220914164321.2156-3-Arvind.Yadav@amd.com \
--to=arvind.yadav@amd.com \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=airlied@linux.ie \
--cc=amaranath.somalapuram@amd.com \
--cc=andrey.grodzovsky@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=shashank.sharma@amd.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®