From: "Paul E. McKenney" <paulmck@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/1] rcu: Simplify rcu_init_nohz() cpumask handling
Date: Thu, 15 Sep 2022 13:25:00 -0700 [thread overview]
Message-ID: <20220915202500.GA346406@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20220914113006.GX246308@paulmck-ThinkPad-P17-Gen-1>
On Wed, Sep 14, 2022 at 04:30:06AM -0700, Paul E. McKenney wrote:
> On Wed, Sep 14, 2022 at 12:46:34PM +0200, Frederic Weisbecker wrote:
> > On Tue, Sep 13, 2022 at 11:00:36AM +0800, Zhen Lei wrote:
> > > In kernels built with either CONFIG_RCU_NOCB_CPU_DEFAULT_ALL=y or
> > > CONFIG_NO_HZ_FULL=y, additional CPUs must be added to rcu_nocb_mask.
> > > Except that kernels booted without the rcu_nocbs= will not have
> > > allocated rcu_nocb_mask. And the current rcu_init_nohz() function uses
> > > its need_rcu_nocb_mask and offload_all local variables to track the
> > > rcu_nocb and nohz_full state.
> > >
> > > But there is a much simpler approach, namely creating a cpumask pointer
> > > to track the default and then using cpumask_available() to check the
> > > rcu_nocb_mask state. This commit takes this approach, thereby simplifying
> > > and shortening the rcu_init_nohz() function.
> > >
> > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> > > Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> > > Acked-by: Frederic Weisbecker <frederic@kernel.org>
> >
> > Looks good, thanks!
>
> Queued and pushed, thank you all!
And this time, actually queued the most recent version. Apologies for
my confusion.
Thanx, Paul
prev parent reply other threads:[~2022-09-15 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 3:00 [PATCH v7 0/1] cu/nocb: Delete local variable 'need_rcu_nocb_mask' in rcu_init_nohz() Zhen Lei
2022-09-13 3:00 ` [PATCH v7 1/1] rcu: Simplify rcu_init_nohz() cpumask handling Zhen Lei
2022-09-14 10:46 ` Frederic Weisbecker
2022-09-14 11:30 ` Paul E. McKenney
2022-09-15 20:25 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915202500.GA346406@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®