From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997B8C6FA91 for ; Mon, 19 Sep 2022 10:47:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbiISKrO (ORCPT ); Mon, 19 Sep 2022 06:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbiISKqo (ORCPT ); Mon, 19 Sep 2022 06:46:44 -0400 Received: from outbound-smtp55.blacknight.com (outbound-smtp55.blacknight.com [46.22.136.239]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF1F427FE3 for ; Mon, 19 Sep 2022 03:31:39 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp55.blacknight.com (Postfix) with ESMTPS id EA4AFFA79E for ; Mon, 19 Sep 2022 11:22:26 +0100 (IST) Received: (qmail 20035 invoked from network); 19 Sep 2022 10:22:26 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Sep 2022 10:22:26 -0000 Date: Mon, 19 Sep 2022 11:16:29 +0100 From: Mel Gorman To: "zhaoyang.huang" Cc: Andrew Morton , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [RFC PATCH] mm: check global free_list if there is ongoing reclaiming when pcp fail Message-ID: <20220919101629.xlafi2y2dk357wk3@techsingularity.net> References: <1663325892-9825-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1663325892-9825-1-git-send-email-zhaoyang.huang@unisoc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 06:58:12PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Check the global free list again even if rmqueue_bulk failed for pcp pages when > there is ongoing reclaiming, which could eliminate potential direct reclaim by > chance. > > Signed-off-by: Zhaoyang Huang Patch does not apply and may be based on a custom kernel that introduced a problem. There is no description of what problem this is trying to fix. Checking the status of reclaim for a specific zone in this path would be a little unexpected. If allocation pressure is exceeding the ability of reclaim to make progress then the caller likely needs to take action like direct reclaim. If the allocation failure is due to a high-order failure then it may need to enter direct compaction etc. -- Mel Gorman SUSE Labs