From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA158C54EE9 for ; Mon, 19 Sep 2022 10:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbiISKuH (ORCPT ); Mon, 19 Sep 2022 06:50:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbiISKtP (ORCPT ); Mon, 19 Sep 2022 06:49:15 -0400 Received: from outbound-smtp59.blacknight.com (outbound-smtp59.blacknight.com [46.22.136.243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757372C11F for ; Mon, 19 Sep 2022 03:42:22 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp59.blacknight.com (Postfix) with ESMTPS id 195E1FA832 for ; Mon, 19 Sep 2022 11:42:21 +0100 (IST) Received: (qmail 11852 invoked from network); 19 Sep 2022 10:42:20 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Sep 2022 10:42:20 -0000 Date: Mon, 19 Sep 2022 11:42:14 +0100 From: Mel Gorman To: "zhaoyang.huang" Cc: Andrew Morton , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCH] mm: check high-order page when free it to pcp Message-ID: <20220919104158.6vbzmzxk2dy6tu6w@techsingularity.net> References: <1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2022 at 11:47:18AM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > High-order pcp page escaped from checking when both of DEBUG_VM and debug_pagealloc > are all disabled if it allocated again from pcp_list without going to global > free list, which should be introduced by 44042b4498. > > fix:44042b4498 > > Signed-off-by: Zhaoyang Huang Is this based on the comment mentioning order-0 pages above free_pcp_prepare()? I ask because the comment is wrong and in both instances should have s/order-0// -- Mel Gorman SUSE Labs