From: Daniel Wagner <dwagner@suse.de>
To: Ren Zhijie <renzhijie2@huawei.com>
Cc: njavali@marvell.com, GR-QLogic-Storage-Upstream@marvell.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
aeasi@marvell.com, himanshu.madhani@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 -next] scsi: qla2xxx: Fix build error implicit-function-declaration
Date: Mon, 19 Sep 2022 16:11:44 +0200 [thread overview]
Message-ID: <20220919141144.h2dw57cmjs2egwep@carbon.lan> (raw)
In-Reply-To: <20220919133404.85425-1-renzhijie2@huawei.com>
On Mon, Sep 19, 2022 at 09:34:04PM +0800, Ren Zhijie wrote:
> If CONFIG_TRACING is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-,
> will be failed, like this:
>
> drivers/scsi/qla2xxx/qla_os.c: In function ‘qla_trace_init’:
> drivers/scsi/qla2xxx/qla_os.c:2854:18: error: implicit declaration of function ‘trace_array_get_by_name’; did you mean ‘trace_array_set_clr_event’? [-Werror=implicit-function-declaration]
> qla_trc_array = trace_array_get_by_name("qla2xxx");
> ^~~~~~~~~~~~~~~~~~~~~~~
> trace_array_set_clr_event
> drivers/scsi/qla2xxx/qla_os.c:2854:16: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
> qla_trc_array = trace_array_get_by_name("qla2xxx");
> ^
> drivers/scsi/qla2xxx/qla_os.c: In function ‘qla_trace_uninit’:
> drivers/scsi/qla2xxx/qla_os.c:2869:2: error: implicit declaration of function ‘trace_array_put’; did you mean ‘trace_seq_putc’? [-Werror=implicit-function-declaration]
> trace_array_put(qla_trc_array);
> ^~~~~~~~~~~~~~~
> trace_seq_putc
> cc1: all warnings being treated as errors
>
> To fix this error, wrap up all the relevant code with CONFIG_TRACING.
>
> Fixes: 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
next prev parent reply other threads:[~2022-09-19 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 13:34 Ren Zhijie
2022-09-19 14:11 ` Daniel Wagner [this message]
2022-09-19 17:54 ` [EXT] " Arun Easi
2022-09-19 18:50 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919141144.h2dw57cmjs2egwep@carbon.lan \
--to=dwagner@suse.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=aeasi@marvell.com \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
--cc=renzhijie2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®