From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF24AC54EE9 for ; Tue, 20 Sep 2022 10:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbiITKCK (ORCPT ); Tue, 20 Sep 2022 06:02:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229985AbiITKCB (ORCPT ); Tue, 20 Sep 2022 06:02:01 -0400 Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B54994D16B; Tue, 20 Sep 2022 03:02:00 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id DB151205CD; Tue, 20 Sep 2022 12:01:58 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bo3VPAwjhi2n; Tue, 20 Sep 2022 12:01:58 +0200 (CEST) Received: from mailout1.secunet.com (mailout1.secunet.com [62.96.220.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 6695D2052E; Tue, 20 Sep 2022 12:01:58 +0200 (CEST) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout1.secunet.com (Postfix) with ESMTP id 549A580004A; Tue, 20 Sep 2022 12:01:58 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 12:01:58 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 12:01:57 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id B086E31829FB; Tue, 20 Sep 2022 12:01:57 +0200 (CEST) Date: Tue, 20 Sep 2022 12:01:57 +0200 From: Steffen Klassert To: Li Zhong CC: , , , , , , , Subject: Re: [PATCH v1] drivers/net/ethernet/3com: check the return value of vortex_up() Message-ID: <20220920100157.GV2950045@gauss3.secunet.de> References: <20220919073631.1574577-1-floridsleeves@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220919073631.1574577-1-floridsleeves@gmail.com> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2022 at 12:36:31AM -0700, Li Zhong wrote: > Check the return value of vortex_up(), which could be error code when > the rx ring is not full. > > Signed-off-by: Li Zhong > --- > drivers/net/ethernet/3com/3c59x.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c > index ccf07667aa5e..7806c5f60ac8 100644 > --- a/drivers/net/ethernet/3com/3c59x.c > +++ b/drivers/net/ethernet/3com/3c59x.c > @@ -1942,6 +1942,7 @@ vortex_error(struct net_device *dev, int status) > void __iomem *ioaddr = vp->ioaddr; > int do_tx_reset = 0, reset_mask = 0; > unsigned char tx_status = 0; > + int err; > > if (vortex_debug > 2) { > pr_err("%s: vortex_error(), status=0x%x\n", dev->name, status); > @@ -2016,7 +2017,9 @@ vortex_error(struct net_device *dev, int status) > /* Must not enter D3 or we can't legally issue the reset! */ > vortex_down(dev, 0); > issue_and_wait(dev, TotalReset | 0xff); > - vortex_up(dev); /* AKPM: bug. vortex_up() assumes that the rx ring is full. It may not be. */ > + err = vortex_up(dev); > + if (err) > + return; Why does that fix the bug mentioned in the above comment?