From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A8BECAAD8 for ; Wed, 21 Sep 2022 08:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbiIUI2L (ORCPT ); Wed, 21 Sep 2022 04:28:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbiIUI1x (ORCPT ); Wed, 21 Sep 2022 04:27:53 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FDED12778 for ; Wed, 21 Sep 2022 01:27:46 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id go6so5692330pjb.2 for ; Wed, 21 Sep 2022 01:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date; bh=5AT8mOkKWjY5PWdM9jcjIYkswAmUffltx4x7PbMSoHI=; b=djiaXEiyV8nu1S2vVKUxdA6Mg8lW0dwLT3uGAPMS7ENbuq+sG8AFf7gIaIWr2ZWY5Y 1TZBz2LWhVJ5s2J/DUYzl5FUA9kCR31TKNkB7xKwdP2GVYtJrfh1PAH8MXuH1yZy6qN9 aSWHqY2QpCU95iIGviFJ/1TdozsEUzzsaFnhs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date; bh=5AT8mOkKWjY5PWdM9jcjIYkswAmUffltx4x7PbMSoHI=; b=QC3OSKFbYQVX0pYHoDEgAEmClbHP02zlIcW94Qzz9nmREFfDLB5E/ORyggKMEEBYIO JZ6uJrPMvMMsT4CQGtLzVlD7jdRp6/MiJvWSfX4NeYRxwbt9O2LWtBmpOwSzYvDBbvh2 ILlYMtHpMH75wOpc+PR0SVn5wQ1nE9KFGN0620IyFq8nNJRHIY/+xjCGRaYPPpyUCFmQ JOeCzeTD1nBoLpqkpOq82t1/PeholQcldw58ZpjXY0zZBzA+lWzKg7YQ+UfsKXrmDtH9 g/kVQZJB4h/e8Raly/4S1rMyb1k18wCRf0CEr6vKR2lREaGXk7CBAJtN3Q5GOEHFpeeM nlWQ== X-Gm-Message-State: ACrzQf23kWHxijY+hVgU+XB/MeseqcQiMq4laDRQt8DFUoB601P+PqGM cUEJTtgAvYMVDckLd9gb4UBeAA== X-Google-Smtp-Source: AMsMyM6dMk7BgaHyy8W1l5PZ4gjmxp4MolRVNSdMI32fir6PU+gJStSn6cHQyCyuWs0A6yjWaJmtrg== X-Received: by 2002:a17:90b:38cb:b0:203:100:bb53 with SMTP id nn11-20020a17090b38cb00b002030100bb53mr8401805pjb.107.1663748866049; Wed, 21 Sep 2022 01:27:46 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:cc93:90d7:674f:156a]) by smtp.gmail.com with ESMTPSA id q12-20020a170902eb8c00b0016dbe37cebdsm1296944plg.246.2022.09.21.01.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 01:27:45 -0700 (PDT) From: Hidenori Kobayashi X-Google-Original-From: Hidenori Kobayashi Date: Wed, 21 Sep 2022 17:27:42 +0900 To: Sakari Ailus Cc: Hidenori Kobayashi , Dongchun Zhu , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: ov8856: Add runtime PM callbacks Message-ID: <20220921082742.bhdgpxzuk32hfgvc@google.com> References: <20220921081536.2551789-1-hidenorik@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sakari, On Wed, Sep 21, 2022 at 11:20:12AM +0300, Sakari Ailus wrote: > Hi Hidenori, > > On Wed, Sep 21, 2022 at 05:15:35PM +0900, Hidenori Kobayashi wrote: > > > > +static int __maybe_unused ov8856_runtime_suspend(struct device *dev) > > +{ > > + __ov8856_power_off(dev); > > + > > + return 0; > > +} > > + > > +static int __maybe_unused ov8856_runtime_resume(struct device *dev) > > +{ > > + return __ov8856_power_on(dev); > > +} > > These two functions are redundant now, you can call __ov8856_power_on / > __ov8856_power_off directly. The return type of __ov8856_power_off needs to > be changed to int. You could also remove the underscores from the names at > the same time. Will fix it as above. I just wasn't sure about the policy. Thanks! Best regards, Hidenori