From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michał Kępień" <kernel@kempniu.pl>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] mtd: track maximum number of bitflips for each read request
Date: Wed, 21 Sep 2022 10:41:20 +0200 [thread overview]
Message-ID: <20220921084120.733357-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220629125737.14418-2-kernel@kempniu.pl>
On Wed, 2022-06-29 at 12:57:34 UTC, =?utf-8?b?TWljaGHFgiBLxJlwaWXFhA==?= wrote:
> mtd_read_oob() callers are currently oblivious to the details of ECC
> errors detected during the read operation - they only learn (through the
> return value) whether any corrected bitflips or uncorrectable errors
> occurred. More detailed ECC information can be useful to user-space
> applications for making better-informed choices about moving data
> around.
>
> Extend struct mtd_oob_ops with a pointer to a newly-introduced struct
> mtd_req_stats and set its 'max_bitflips' field to the maximum number of
> bitflips found in a single ECC step during the read operation performed
> by mtd_read_oob(). This is a prerequisite for ultimately passing that
> value back to user space.
>
> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
next prev parent reply other threads:[~2022-09-21 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 12:57 [PATCH v4 0/4] mtdchar: add MEMREAD ioctl Michał Kępień
2022-06-29 12:57 ` [PATCH v4 1/4] mtd: track maximum number of bitflips for each read request Michał Kępień
2022-09-21 8:41 ` Miquel Raynal [this message]
2022-06-29 12:57 ` [PATCH v4 2/4] mtd: always initialize 'stats' in struct mtd_oob_ops Michał Kępień
2022-09-21 8:41 ` Miquel Raynal
2022-06-29 12:57 ` [PATCH v4 3/4] mtd: add ECC error accounting for each read request Michał Kępień
2022-09-21 8:40 ` Miquel Raynal
2022-06-29 12:57 ` [PATCH v4 4/4] mtdchar: add MEMREAD ioctl Michał Kępień
2022-09-20 19:11 ` Richard Weinberger
2022-09-21 8:40 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921084120.733357-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@collabora.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®