From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D20BDECAAD8 for ; Wed, 21 Sep 2022 15:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbiIUPne (ORCPT ); Wed, 21 Sep 2022 11:43:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229987AbiIUPnY (ORCPT ); Wed, 21 Sep 2022 11:43:24 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D722CE00E; Wed, 21 Sep 2022 08:43:23 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E83F13D5; Wed, 21 Sep 2022 08:43:29 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0DBC83F73D; Wed, 21 Sep 2022 08:43:21 -0700 (PDT) Date: Wed, 21 Sep 2022 16:43:19 +0100 From: Sudeep Holla To: Huisong Li Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org, rafael.j.wysocki@intel.com, wanghuiqiang@huawei.com, huangdaode@huawei.com Subject: Re: [PATCH 2/2] ACPI: PCC: fix Tx done interface in handler Message-ID: <20220921154319.bsczh2nftuypeucs@bogus> References: <20220920094500.11283-1-lihuisong@huawei.com> <20220920094500.11283-3-lihuisong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920094500.11283-3-lihuisong@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 05:45:00PM +0800, Huisong Li wrote: > A error, "Client can't run the TX ticker", is printed even if PCC command > executed successfully. This root cause is that PCC handler calls > 'mbox_client_txdone()' which depands on the client can received 'ACK' > packet. But PCC handler detects whether the command is complete through > the Tx ACK interrupt. So this patch fix it. > Thanks for fixing this. Someone mentioned about the error and it was in my TODO list. I would prefer to reword the subject and commit message as below: " ACPI: PCC: Fix Tx acknowledge in the PCC address space handler Currently, mbox_client_txdone() is called from the PCC address space handler and that expects the user the Tx state machine to be controlled by the client which is not the case and the below warning is thrown: | PCCT: Client can't run the TX ticker Let the controller run the state machine and the end of Tx can be acknowledge by calling mbox_chan_txdone() instead. " With that: Reviewed-by: Sudeep Holla -- Regards, Sudeep