mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qais Yousef <qais.yousef@arm.com>
To: Tejun Heo <tj@kernel.org>, Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
	mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	bristot@redhat.com, vschneid@redhat.com,
	linux-kernel@vger.kernel.org, parth@linux.ibm.com,
	chris.hyser@oracle.com, valentin.schneider@arm.com,
	patrick.bellasi@matbug.net, David.Laight@aculab.com,
	pjt@google.com, pavel@ucw.cz, qperret@google.com,
	tim.c.chen@linux.intel.com, joshdon@google.com
Subject: Re: [PATCH v4 6/8] sched/fair: Add sched group latency support
Date: Wed, 21 Sep 2022 17:07:38 +0100	[thread overview]
Message-ID: <20220921155521.qb3jb74nbjoenau6@airbuntu> (raw)
In-Reply-To: <YyioI4iBFq8ib9JT@slm.duckdns.org>

On 09/19/22 07:34, Tejun Heo wrote:
> On Mon, Sep 19, 2022 at 05:49:27PM +0200, Vincent Guittot wrote:
> > > For `nice` we have `cpu.weight.nice` next to `cpu.weight` in cgroup v2 ?
> > 
> > If everybody is ok, I can add back the cpu.latency.nice interface in
> > the v5 in addition to the cpu.latency
> 
> Yeah, that sounds fine to me.

I do have concerns about cpu.latency knob as it exposes latency_offset which
won't be meaningful for all consumers of latency_nice [1].

The current use case proposed by Vincent is not going to be the only consumer
of this interface. The concept of converting this latency_nice value to weight
in similar fashion to existing nice value is specific to it. In previous
discussion this conversion was not required and I'd expect it to still not be
required for those other use cases.

Wouldn't cpu.latency.nice be enough? I think the latency_offset is
implementation detail that userspace shouldn't be concerned about.


[1] https://lwn.net/Articles/820659/


Cheers

--
Qais Yousef

  parent reply	other threads:[~2022-09-21 16:26 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16  8:02 [PATCH v4 0/8] Add latency priority for CFS class Vincent Guittot
2022-09-16  8:02 ` [PATCH v4 1/8] sched: Introduce latency-nice as a per-task attribute Vincent Guittot
2022-09-16  8:02 ` [PATCH v4 2/8] sched/core: Propagate parent task's latency requirements to the child task Vincent Guittot
2022-09-16  8:03 ` [PATCH v4 3/8] sched: Allow sched_{get,set}attr to change latency_nice of the task Vincent Guittot
2022-09-16  8:03 ` [PATCH v4 4/8] sched/core: Add permission checks for setting the latency_nice value Vincent Guittot
2022-09-19  8:52   ` timj
2022-09-19  8:52     ` timj
2022-09-19 12:41     ` Vincent Guittot
2022-09-20 10:18       ` Tim Janik
2022-09-20 14:56         ` Vincent Guittot
2022-09-21 16:11           ` Vincent Guittot
2022-09-16  8:03 ` [PATCH v4 5/8] sched/fair: Take into account latency priority at wakeup Vincent Guittot
     [not found]   ` <20220916120245.2951-1-hdanton@sina.com>
2022-09-16 13:36     ` Vincent Guittot
     [not found]       ` <20220917225819.817-1-hdanton@sina.com>
2022-09-18 10:46         ` Vincent Guittot
     [not found]           ` <20220920113238.1176-1-hdanton@sina.com>
2022-09-20 15:17             ` Vincent Guittot
2022-09-19 10:05   ` Dietmar Eggemann
2022-09-19 15:39     ` Vincent Guittot
2022-09-20 13:18       ` Dietmar Eggemann
2022-09-20 15:49         ` Vincent Guittot
2022-09-21 22:41           ` Dietmar Eggemann
2022-09-22  7:12             ` Vincent Guittot
2022-09-22 16:50               ` Dietmar Eggemann
2022-09-23  6:01                 ` Vincent Guittot
2022-09-16  8:03 ` [PATCH v4 6/8] sched/fair: Add sched group latency support Vincent Guittot
2022-09-19 11:55   ` Dietmar Eggemann
2022-09-19 15:49     ` Vincent Guittot
2022-09-19 17:34       ` Tejun Heo
2022-09-20  7:03         ` Vincent Guittot
2022-09-21 16:07         ` Qais Yousef [this message]
2022-09-21 16:48           ` Tejun Heo
2022-09-21 17:02             ` Vincent Guittot
2022-09-21 17:12               ` Tejun Heo
2022-09-22  6:40                 ` Vincent Guittot
2022-09-22 10:49                   ` Qais Yousef
2022-09-20 18:17       ` Dietmar Eggemann
2022-09-21  7:48         ` Vincent Guittot
2022-09-19 17:34     ` Tejun Heo
2022-09-20  7:02       ` Vincent Guittot
2022-09-16  8:03 ` [PATCH v4 7/8] sched/core: support latency priority with sched core Vincent Guittot
2022-09-16  8:03 ` [PATCH v4 8/8] sched/fair: Add latency list Vincent Guittot
2022-09-21 16:08 ` [PATCH v4 0/8] Add latency priority for CFS class Qais Yousef
2022-09-22  7:19   ` Vincent Guittot
2022-09-22 11:00     ` Qais Yousef
2022-09-22 13:03       ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921155521.qb3jb74nbjoenau6@airbuntu \
    --to=qais.yousef@arm.com \
    --cc=David.Laight@aculab.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=chris.hyser@oracle.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joshdon@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=parth@linux.ibm.com \
    --cc=patrick.bellasi@matbug.net \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=qperret@google.com \
    --cc=rostedt@goodmis.org \
    --cc=tim.c.chen@linux.intel.com \
    --cc=tj@kernel.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®