From: Rafael Mendonca <rafaelmendsr@gmail.com>
To: Raju Rangoju <rajur@chelsio.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: Rafael Mendonca <rafaelmendsr@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH net-next 0/1] cxgb4: fix missing unlock on ETHOFLD desc collect fail path
Date: Thu, 22 Sep 2022 02:32:35 -0300 [thread overview]
Message-ID: <20220922053237.750832-1-rafaelmendsr@gmail.com> (raw)
I'm sending this as a RFC because I'm not familiar with the chelsio
cxgb4 code, sorry if this is nonsense.
I noticed that the 'out' label is passed to the QDESC_GET for the
ETHOFLD TXQ, RXQ, and FLQ, which skips the 'out_unlock' label on error,
and thus doesn't unlock the 'uld_mutex' before returning.
I was thinking the solution would be to simply change the label to
'out_unlock'. However, since commit 5148e5950c67 ("cxgb4: add EOTID
tracking and software context dump"), I was wondering if the access to
these ETHOFLD hardware queues should be protected by the 'mqprio_mutex'
instead of the 'uld_mutex'.
Rafael Mendonca (1):
cxgb4: fix missing unlock on ETHOFLD desc collect fail path
.../net/ethernet/chelsio/cxgb4/cudbg_lib.c | 28 +++++++++++++------
1 file changed, 19 insertions(+), 9 deletions(-)
--
2.34.1
next reply other threads:[~2022-09-22 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 5:32 Rafael Mendonca [this message]
2022-09-22 5:32 ` [RFC PATCH net-next 1/1] " Rafael Mendonca
2022-09-22 9:21 ` Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922053237.750832-1-rafaelmendsr@gmail.com \
--to=rafaelmendsr@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®