Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on broonie-spi/for-next] [also build test ERROR on linus/master v6.0-rc6 next-20220921] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/spi-Introduce-spi_get_device_match_data-helper/20220922-044658 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next config: hexagon-randconfig-r045-20220921 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4d7a10e29738f98137b08b2dcc0297535dd92a11 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/spi-Introduce-spi_get_device_match_data-helper/20220922-044658 git checkout 4d7a10e29738f98137b08b2dcc0297535dd92a11 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/spi/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/spi/spi.c:367:32: error: passing 'const struct device *' to parameter of type 'struct device *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] match = device_get_match_data(&sdev->dev); ^~~~~~~~~~ include/linux/property.h:390:50: note: passing argument to parameter 'dev' here const void *device_get_match_data(struct device *dev); ^ 1 error generated. vim +367 drivers/spi/spi.c 362 363 const void *spi_get_device_match_data(const struct spi_device *sdev) 364 { 365 const void *match; 366 > 367 match = device_get_match_data(&sdev->dev); 368 if (match) 369 return match; 370 371 return (const void *)spi_get_device_id(sdev)->driver_data; 372 } 373 EXPORT_SYMBOL_GPL(spi_get_device_match_data); 374 -- 0-DAY CI Kernel Test Service https://01.org/lkp