From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69A6C32771 for ; Mon, 26 Sep 2022 09:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234169AbiIZJsQ (ORCPT ); Mon, 26 Sep 2022 05:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234058AbiIZJrf (ORCPT ); Mon, 26 Sep 2022 05:47:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27A8210F6 for ; Mon, 26 Sep 2022 02:47:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C5980B80835 for ; Mon, 26 Sep 2022 09:47:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57A24C433C1; Mon, 26 Sep 2022 09:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664185629; bh=8xLc9Jif8RGEMCtgB+VC2cSdX4vlVBUss1vrHW2eBb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cfJxzqZf84aR/mjLTUgTIxo2o/wXWjOirG23mUZ8lG/Q3Ha4dFytBF1sdY9TD1FeI vWgD6oBxMLPZPs3rpf9HOKbDoEtUIRqgJIro82eti7gu+ssVeCspGRSHf3EI4gV/vn GGHQTajn3dx9VvGzizl4CPvTKF3Z66FfxyNW1Orq/0TuHbHH9OKQHrQkF58CrN+01H oN0jmMflfAh9wbYGMSXCfwKybtEYPTZDG5tYN1xUz4dZzYbH7vHPmXDiuVxgdBhnzr 1E8Thj/3COxaj7ECKE+06Srm4iphrY/dLtjtXfFRM5fOJU+8vMOZi+CQw/DQQprQlX Eh/apLml3VWOg== Received: by pali.im (Postfix) id 585CD8A3; Mon, 26 Sep 2022 11:47:06 +0200 (CEST) Date: Mon, 26 Sep 2022 11:47:06 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Christophe Leroy Cc: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Scott Wood , Sinan Akman , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static Message-ID: <20220926094706.km22rqzuuulvfssq@pali> References: <20220819191557.28116-1-pali@kernel.org> <20220819191557.28116-3-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 26 September 2022 09:43:55 Christophe Leroy wrote: > Le 19/08/2022 à 21:15, Pali Rohár a écrit : > > Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file. > > > > Signed-off-by: Pali Rohár > > This patch should be squashed into patch 1. No problem. Just to explain that I split those changes into different patches because they touch different files and different board code. And I thought that different things should be in different patches. > > --- > > arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > index f8d2c97f39bd..9a6d637ef54a 100644 > > --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc) > > } > > #endif /* CONFIG_PPC_I8259 */ > > > > -void __init mpc85xx_ds_pic_init(void) > > +static void __init mpc85xx_ds_pic_init(void) > > { > > struct mpic *mpic; > > #ifdef CONFIG_PPC_I8259