From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5560DC32771 for ; Mon, 26 Sep 2022 17:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230157AbiIZR2y (ORCPT ); Mon, 26 Sep 2022 13:28:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230494AbiIZR2b (ORCPT ); Mon, 26 Sep 2022 13:28:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 392AB92F60 for ; Mon, 26 Sep 2022 09:45:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 94F6960F61 for ; Mon, 26 Sep 2022 16:45:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E416DC433D6; Mon, 26 Sep 2022 16:45:43 +0000 (UTC) Date: Mon, 26 Sep 2022 12:46:51 -0400 From: Steven Rostedt To: Nadav Amit Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, x86@kernel.org, Dave Hansen , Borislav Petkov , Ingo Molnar , Nadav Amit , "Peter Zijlstra (Intel)" Subject: Re: [RFC PATCH] x86/syscalls: allow tracing of __do_sys_[syscall] functions Message-ID: <20220926124651.5d35dd5f@gandalf.local.home> In-Reply-To: <20220913135213.720368-1-namit@vmware.com> References: <20220913135213.720368-1-namit@vmware.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Sep 2022 06:52:13 -0700 Nadav Amit wrote: > +++ b/include/linux/compiler_types.h > @@ -152,8 +152,12 @@ struct ftrace_likely_data { > * externally visible function. This makes extern inline behave as per gnu89 > * semantics rather than c99. This prevents multiple symbol definition errors > * of extern inline functions at link time. > - * A lot of inline functions can cause havoc with function tracing. > + * > + * A lot of inline functions can cause havoc with function tracing. If the > + * function is known to be safe for tracing, inline_trace can be used. Otherwise > + * inline would prevent tracing. Perhaps add: * Don't complain if this function is not available to trace! ;-) -- Steve > */ > +#define inline_trace __inline __gnu_inline __inline_maybe_unused > #define inline inline __gnu_inline __inline_maybe_unused notrace >