From: James Clark <james.clark@arm.com>
To: acme@kernel.org, namhyung@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
James Clark <james.clark@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH 0/1] perf test: Fix attr tests for PERF_FORMAT_LOST
Date: Mon, 26 Sep 2022 15:49:46 +0100 [thread overview]
Message-ID: <20220926144948.223641-1-james.clark@arm.com> (raw)
I'm not sure what the rule is for backwards compatibility of tests, but
in this case my change will not work on older kernels because I replaced
the previous expected value, rather than adding it as another valid one
with an OR. Like "read_format=4|20"
To me it seems that running the tests is a different workflow than say
someone running Perf itself on older kernels. And if we keep adding to
the valid values in tests, then the tests become less useful over time.
PERF_FORMAT_LOST is not an optional feature so it _should_ always be
present. For that reason I chose to not add it as an extra valid value,
but I'm happy to change it if we think that new tests should also pass
on older kernels.
Thanks
James
James Clark (1):
perf test: Fix attr tests for PERF_FORMAT_LOST
tools/perf/tests/attr/base-record | 2 +-
tools/perf/tests/attr/system-wide-dummy | 2 +-
tools/perf/tests/attr/test-record-group | 4 ++--
tools/perf/tests/attr/test-record-group-sampling | 6 +++---
tools/perf/tests/attr/test-record-group1 | 4 ++--
tools/perf/tests/attr/test-record-group2 | 4 ++--
6 files changed, 11 insertions(+), 11 deletions(-)
--
2.28.0
next reply other threads:[~2022-09-26 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 14:49 James Clark [this message]
2022-09-26 14:49 ` [PATCH 1/1] " James Clark
2022-10-11 13:00 ` James Clark
2022-10-11 17:48 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926144948.223641-1-james.clark@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®