From: Jason Yan <yanaijie@huawei.com>
To: <martin.petersen@oracle.com>, <jejb@linux.ibm.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hare@suse.com>, <hch@lst.de>, <bvanassche@acm.org>,
<john.garry@huawei.com>, <jinpu.wang@cloud.ionos.com>,
Jason Yan <yanaijie@huawei.com>
Subject: [PATCH v3 1/8] scsi: libsas: introduce sas address comparation helpers
Date: Tue, 27 Sep 2022 10:29:34 +0800 [thread overview]
Message-ID: <20220927022941.4029476-2-yanaijie@huawei.com> (raw)
In-Reply-To: <20220927022941.4029476-1-yanaijie@huawei.com>
Sas address comparation is widely used in libsas. However they are all
opencoded and to avoid the line spill over 80 columns, are mostly split
into multi-lines. Introduce some helpers to prepare some refactor.
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/libsas/sas_internal.h | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/scsi/libsas/sas_internal.h b/drivers/scsi/libsas/sas_internal.h
index 8d0ad3abc7b5..3384429b7eb0 100644
--- a/drivers/scsi/libsas/sas_internal.h
+++ b/drivers/scsi/libsas/sas_internal.h
@@ -111,6 +111,23 @@ static inline void sas_smp_host_handler(struct bsg_job *job,
}
#endif
+static inline bool sas_phy_match_dev_addr(struct domain_device *dev,
+ struct ex_phy *phy)
+{
+ return SAS_ADDR(dev->sas_addr) == SAS_ADDR(phy->attached_sas_addr);
+}
+
+static inline bool sas_phy_match_port_addr(struct asd_sas_port *port,
+ struct ex_phy *phy)
+{
+ return SAS_ADDR(port->sas_addr) == SAS_ADDR(phy->attached_sas_addr);
+}
+
+static inline bool sas_phy_addr_match(struct ex_phy *p1, struct ex_phy *p2)
+{
+ return SAS_ADDR(p1->attached_sas_addr) == SAS_ADDR(p2->attached_sas_addr);
+}
+
static inline void sas_fail_probe(struct domain_device *dev, const char *func, int err)
{
pr_warn("%s: for %s device %016llx returned %d\n",
--
2.31.1
next prev parent reply other threads:[~2022-09-27 2:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 2:29 [PATCH v3 0/8] scsi: libsas: sas address comparation refactor Jason Yan
2022-09-27 2:29 ` Jason Yan [this message]
2022-09-27 2:23 ` [PATCH v3 1/8] scsi: libsas: introduce sas address comparation helpers Damien Le Moal
2022-09-27 2:44 ` Jason Yan
2022-09-27 2:29 ` [PATCH v3 2/8] scsi: libsas: introduce sas_find_attached_phy() helper Jason Yan
2022-09-27 2:24 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 3/8] scsi: pm8001: use sas_find_attached_phy() instead of open coded Jason Yan
2022-09-27 2:25 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 4/8] scsi: mvsas: " Jason Yan
2022-09-27 2:27 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 5/8] scsi: hisi_sas: use sas_find_attathed_phy() " Jason Yan
2022-09-27 2:28 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 6/8] scsi: libsas: use sas_phy_match_dev_addr() " Jason Yan
2022-09-27 2:30 ` Damien Le Moal
2022-09-27 2:35 ` Jason Yan
2022-09-27 2:29 ` [PATCH v3 7/8] scsi: libsas: use sas_phy_addr_match() " Jason Yan
2022-09-27 2:31 ` Damien Le Moal
2022-09-27 2:29 ` [PATCH v3 8/8] scsi: libsas: use sas_phy_match_port_addr() " Jason Yan
2022-09-27 2:32 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927022941.4029476-2-yanaijie@huawei.com \
--to=yanaijie@huawei.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®