From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63971C07E9D for ; Tue, 27 Sep 2022 11:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231641AbiI0L4d (ORCPT ); Tue, 27 Sep 2022 07:56:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232147AbiI0L43 (ORCPT ); Tue, 27 Sep 2022 07:56:29 -0400 Received: from hi1smtp01.de.adit-jv.com (smtp1.de.adit-jv.com [93.241.18.167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11DE715566B for ; Tue, 27 Sep 2022 04:56:25 -0700 (PDT) Received: from hi2exch02.adit-jv.com (hi2exch02.adit-jv.com [10.72.92.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hi1smtp01.de.adit-jv.com (Postfix) with ESMTPS id 59A42520214; Tue, 27 Sep 2022 13:56:24 +0200 (CEST) Received: from lxhi-065 (10.72.94.21) by hi2exch02.adit-jv.com (10.72.92.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Tue, 27 Sep 2022 13:56:23 +0200 Date: Tue, 27 Sep 2022 13:56:19 +0200 From: Eugeniu Rosca To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= CC: Eugeniu Rosca , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , , , Yanmin Zhang , Eugeniu Rosca , Jiada Wang , Zhang Yanmin , Ramesh Babu , Dean Jenkins , Ramesh Babu B , xiao jin , Cezary Rojewski Subject: Re: [PATCH] ASoC: soc-pcm: fix fe and be race when accessing substream->runtime Message-ID: <20220927115619.GA4547@lxhi-065> References: <1664210154-11552-1-git-send-email-erosca@de.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.72.94.21] X-ClientProxiedBy: hi2exch02.adit-jv.com (10.72.92.28) To hi2exch02.adit-jv.com (10.72.92.28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Amadeusz, On Di, Sep 27, 2022 at 09:34:49 +0200, Amadeusz Sławiński wrote: > On 9/26/2022 6:35 PM, Eugeniu Rosca wrote: > >From: xiao jin > > > >After start of fe and be, fe might go to close without triggering > >STOP, and substream->runtime is freed. However, be is still at > >START state and its substream->runtime still points to the > >freed runtime. > > > > Well if it is being freed, maybe pointer should be set to NULL instead in > place that happens? > As soon as the agreement is reached that the patch is still relevant/useful on the latest vanilla, I think this review finding will receive proper attention. Thanks, Eugeniu