From: Steffen Klassert <steffen.klassert@secunet.com>
To: Christian Langrock <christian.langrock@secunet.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-ipsec v2] xfrm: replay: Fix ESN wrap around for GSO
Date: Wed, 28 Sep 2022 08:49:07 +0200 [thread overview]
Message-ID: <20220928064907.GU566407@gauss3.secunet.de> (raw)
In-Reply-To: <fe554921-104e-2365-a09b-812a1cedac65@secunet.com>
On Tue, Sep 27, 2022 at 02:59:50PM +0200, Christian Langrock wrote:
> When using GSO it can happen that the wrong seq_hi is used for the last
> packets before the wrap around. This can lead to double usage of a
> sequence number. To avoid this, we should serialize this last GSO
> packet.
>
> Fixes: d7dbefc45cf5 ("xfrm: Add xfrm_replay_overflow functions for...")
> Signed-off-by: Christian Langrock <christian.langrock@secunet.com>
Some minor nits:
This is already v3, not v2 as stated in the subject line.
Also, please explain the changes between the versions
(see 'git log' for examples).
The target tree is 'ipsec', not 'net-ipsec'.
Otherwise this is a fix for a real bug. So fix the build,
incorporate the review from Leon and send a v4.
Thanks!
next prev parent reply other threads:[~2022-09-28 6:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 12:59 Christian Langrock
2022-09-27 14:22 ` Jakub Kicinski
2022-09-28 6:18 ` Leon Romanovsky
2022-09-28 6:49 ` Steffen Klassert [this message]
2022-09-28 21:28 ` kernel test robot
2022-09-28 21:29 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-09-27 12:03 Christian Langrock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928064907.GU566407@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=christian.langrock@secunet.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®