From: Khalid Masum <khalid.masum.92@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Khalid Masum <khalid.masum.92@gmail.com>
Subject: [PATCH] drm/tve200: Use drm_* variants for logging
Date: Wed, 28 Sep 2022 15:31:03 +0600 [thread overview]
Message-ID: <20220928093103.64014-1-khalid.masum.92@gmail.com> (raw)
We have routines like drm_info/warn/err for logging. Use them instead
of dev_* variants to get drm-formatted log messages.
Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
---
drivers/gpu/drm/tve200/tve200_display.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/tve200/tve200_display.c b/drivers/gpu/drm/tve200/tve200_display.c
index 771bad881714..d453581b6b18 100644
--- a/drivers/gpu/drm/tve200/tve200_display.c
+++ b/drivers/gpu/drm/tve200/tve200_display.c
@@ -60,7 +60,7 @@ irqreturn_t tve200_irq(int irq, void *data)
}
writel(val, priv->regs + TVE200_CTRL);
} else
- dev_err(priv->drm->dev, "stray IRQ %08x\n", stat);
+ drm_err(priv->drm, "stray IRQ %08x\n", stat);
/* Clear the interrupt once done */
writel(stat, priv->regs + TVE200_INT_CLR);
@@ -146,7 +146,7 @@ static void tve200_display_enable(struct drm_simple_display_pipe *pipe,
}
if (retries == 5 &&
readl(priv->regs + TVE200_CTRL_4) & TVE200_CTRL_4_RESET) {
- dev_err(drm->dev, "can't get hardware out of reset\n");
+ drm_err(drm, "can't get hardware out of reset\n");
return;
}
@@ -171,14 +171,14 @@ static void tve200_display_enable(struct drm_simple_display_pipe *pipe,
if ((mode->hdisplay == 352 && mode->vdisplay == 240) || /* SIF(525) */
(mode->hdisplay == 352 && mode->vdisplay == 288)) { /* CIF(625) */
ctrl1 |= TVE200_CTRL_IPRESOL_CIF;
- dev_info(drm->dev, "CIF mode\n");
+ drm_info(drm, "CIF mode\n");
} else if (mode->hdisplay == 640 && mode->vdisplay == 480) {
ctrl1 |= TVE200_CTRL_IPRESOL_VGA;
- dev_info(drm->dev, "VGA mode\n");
+ drm_info(drm, "VGA mode\n");
} else if ((mode->hdisplay == 720 && mode->vdisplay == 480) ||
(mode->hdisplay == 720 && mode->vdisplay == 576)) {
ctrl1 |= TVE200_CTRL_IPRESOL_D1;
- dev_info(drm->dev, "D1 mode\n");
+ drm_info(drm, "D1 mode\n");
}
if (format & DRM_FORMAT_BIG_ENDIAN) {
@@ -226,7 +226,7 @@ static void tve200_display_enable(struct drm_simple_display_pipe *pipe,
ctrl1 |= TVE200_IPDMOD_YUV420;
break;
default:
- dev_err(drm->dev, "Unknown FB format 0x%08x\n",
+ drm_err(drm, "Unknown FB format 0x%08x\n",
fb->format->format);
break;
}
--
2.37.3
next reply other threads:[~2022-09-28 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:31 Khalid Masum [this message]
2022-10-03 18:54 ` Linus Walleij
2022-10-09 2:15 ` Khalid Masum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928093103.64014-1-khalid.masum.92@gmail.com \
--to=khalid.masum.92@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®