From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BB0C04A95 for ; Wed, 28 Sep 2022 10:56:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233528AbiI1Kz6 (ORCPT ); Wed, 28 Sep 2022 06:55:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233469AbiI1Kzc (ORCPT ); Wed, 28 Sep 2022 06:55:32 -0400 X-Greylist: delayed 475 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 28 Sep 2022 03:53:53 PDT Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6873140F4 for ; Wed, 28 Sep 2022 03:53:53 -0700 (PDT) From: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1664361955; bh=4jcq0VaC/iDXcd4j2uJ4w0vNny9swybKQkCYoOfOC5k=; h=From:To:Cc:Subject:Date:From; b=Qa9qhGRLkpREYaE4iLS0o/hjjWX1Wzj56X+39n6KNg7ShMYFrVzF8pjEQanUDQN6G nEsK1vk4b/wpIHEGpsP0RUwqY3tZwKYK2NsszSf2Rkgg0KtQZRFsWaB0/26T4IfWmt GcMAWT34lxZGkIJcdcufgZASwm73J8WloKwbbC94= To: Hugh Dickins , Andrew Morton Cc: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Subject: [PATCH] tmpfs: ensure O_LARGEFILE with generic_file_open() Date: Wed, 28 Sep 2022 12:45:35 +0200 Message-Id: <20220928104535.61186-1-linux@weissschuh.net> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=ed25519-sha256; t=1664361931; l=887; i=linux@weissschuh.net; s=20211113; h=from:subject; bh=d66fuy49WyqPJLzFDKOViGXYieS8rDSH8RKJPKnQnVU=; b=a8GADzUi4rhImJ18q5ENvGnE0+4c+H6JL0fbYL7u3mDoLpE4BpFBjsL/oBthgtnwVGEBUnzCk44H 5YLhloXkC2HEYVLv9fvjqfeZgv0Hzkh9R/YXEfnk4E+VlUbnN1Ze X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=9LP6KM4vD/8CwHW7nouRBhWLyQLcK1MkP6aTZbzUlj4= Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Weißschuh Without this check open() will open large files on tmpfs although O_LARGEFILE was not specified. This is inconsistent with other filesystems. Also it will later result in EOVERFLOW on stat() or EFBIG on write(). Link: https://lore.kernel.org/lkml/76bedae6-22ea-4abc-8c06-b424ceb39217@t-8ch.de/ Signed-off-by: Thomas Weißschuh --- mm/shmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/shmem.c b/mm/shmem.c index 42e5888bf84d..902c5550fabc 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3876,6 +3876,7 @@ EXPORT_SYMBOL(shmem_aops); static const struct file_operations shmem_file_operations = { .mmap = shmem_mmap, + .open = generic_file_open, .get_unmapped_area = shmem_get_unmapped_area, #ifdef CONFIG_TMPFS .llseek = shmem_file_llseek, base-commit: f76349cf41451c5c42a99f18a9163377e4b364ff -- 2.37.3