From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [PATCH] clk: imx8mp: register driver at arch_initcall time
Date: Wed, 28 Sep 2022 14:41:08 +0200 [thread overview]
Message-ID: <20220928124108.500369-1-linux@rasmusvillemoes.dk> (raw)
We have an imx8mp-based board with an external gpio-triggered
watchdog. Currently, we don't get to handle that in time before it
resets the board.
The probe of the watchdog device gets deferred because the SOC's GPIO
controller is not yet ready, and the probe of that in turn gets deferred
because its clock provider (namely, this driver) is not yet
ready. Altogether, the watchdog does not get handled until the late
initcall deferred_probe_initcall has made sure all leftover devices
have been probed, and that's way too late.
Aside from being necessary for our board, this also reduces total boot
time because fewer device probes get deferred.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
It would probably be reasonable to do the same to the other imx8m* clk
drivers, but I don't have any such hardware to test on.
drivers/clk/imx/clk-imx8mp.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
index e89db568f5a8..9ddd39a664cc 100644
--- a/drivers/clk/imx/clk-imx8mp.c
+++ b/drivers/clk/imx/clk-imx8mp.c
@@ -734,7 +734,19 @@ static struct platform_driver imx8mp_clk_driver = {
.of_match_table = imx8mp_clk_of_match,
},
};
-module_platform_driver(imx8mp_clk_driver);
+
+static int __init imx8mp_clk_init(void)
+{
+ return platform_driver_register(&imx8mp_clk_driver);
+}
+arch_initcall(imx8mp_clk_init);
+
+static void __exit imx8mp_clk_exit(void)
+{
+ platform_driver_unregister(&imx8mp_clk_driver);
+}
+module_exit(imx8mp_clk_exit);
+
module_param(mcore_booted, bool, S_IRUGO);
MODULE_PARM_DESC(mcore_booted, "See Cortex-M core is booted or not");
--
2.37.2
next reply other threads:[~2022-09-28 12:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 12:41 Rasmus Villemoes [this message]
2022-10-24 13:48 ` Rasmus Villemoes
2022-10-24 14:00 ` Ahmad Fatoum
2022-10-24 14:31 ` Rasmus Villemoes
2022-10-27 23:29 ` Stephen Boyd
2022-10-31 9:15 ` Rasmus Villemoes
2022-11-07 13:54 ` Rasmus Villemoes
2022-11-19 20:45 ` Rasmus Villemoes
2022-11-19 21:38 ` Fabio Estevam
2022-11-19 21:57 ` Rasmus Villemoes
2022-11-19 22:02 ` Fabio Estevam
2022-11-21 9:44 ` Rasmus Villemoes
2022-11-21 10:59 ` Fabio Estevam
2022-11-21 12:29 ` Rasmus Villemoes
2022-11-21 12:48 ` Fabio Estevam
2022-11-21 15:43 ` Abel Vesa
2022-11-22 7:49 ` Rasmus Villemoes
2022-11-23 1:42 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928124108.500369-1-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=abelvesa@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®