From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Sergiu Moga <sergiu.moga@microchip.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Richard Genoud <richard.genoud@gmail.com>,
linux-serial@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>
Subject: [PATCH -next] tty: serial: atmel: driver depends on COMMON_CLK
Date: Wed, 28 Sep 2022 22:48:51 -0700 [thread overview]
Message-ID: <20220929054851.7723-1-rdunlap@infradead.org> (raw)
Since atmel_serial.c uses interfaces that are provided by
the COMMON_CLK Kconfig symbol, the driver should depend on
COMMON_CLK to prevent build errors.
ld: drivers/tty/serial/atmel_serial.o: in function `atmel_serial_pm':
atmel_serial.c:(.text+0x1553): undefined reference to `__clk_is_enabled'
ld: drivers/tty/serial/atmel_serial.o: in function `atmel_set_termios':
atmel_serial.c:(.text+0x1dfe): undefined reference to `__clk_is_enabled'
Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Sergiu Moga <sergiu.moga@microchip.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Richard Genoud <richard.genoud@gmail.com>
Cc: linux-serial@vger.kernel.org
Cc: Jiri Slaby <jirislaby@kernel.org>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -128,6 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
config SERIAL_ATMEL
bool "AT91 on-chip serial port support"
depends on ARCH_AT91 || COMPILE_TEST
+ depends on COMMON_CLK
select SERIAL_CORE
select SERIAL_MCTRL_GPIO if GPIOLIB
select MFD_AT91_USART
next reply other threads:[~2022-09-29 5:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 5:48 Randy Dunlap [this message]
2022-09-29 7:35 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929054851.7723-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=richard.genoud@gmail.com \
--cc=sergiu.moga@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®