Hi Pali, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on linus/master v6.0-rc7 next-20220928] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Pali-Roh-r/PCI-ixp4xx-Use-PCI_CONF1_ADDRESS-macro/20220928-202711 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: arm-allyesconfig compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/956a10e13aa1668f4daae22166ba8da017da9eba git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Pali-Roh-r/PCI-ixp4xx-Use-PCI_CONF1_ADDRESS-macro/20220928-202711 git checkout 956a10e13aa1668f4daae22166ba8da017da9eba # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/pci/controller/pci-ixp4xx.c: In function 'ixp4xx_config_addr': >> drivers/pci/controller/pci-ixp4xx.c:191:25: error: implicit declaration of function 'PCI_CONF1_ADDRESS'; did you mean 'PCI_ROM_ADDRESS'? [-Werror=implicit-function-declaration] 191 | return (PCI_CONF1_ADDRESS(0, 0, PCI_FUNC(devfn), where) & | ^~~~~~~~~~~~~~~~~ | PCI_ROM_ADDRESS >> drivers/pci/controller/pci-ixp4xx.c:192:26: error: 'PCI_CONF1_ENABLE' undeclared (first use in this function); did you mean 'PCI_EA_ENABLE'? 192 | ~PCI_CONF1_ENABLE) | BIT(32-PCI_SLOT(devfn)); | ^~~~~~~~~~~~~~~~ | PCI_EA_ENABLE drivers/pci/controller/pci-ixp4xx.c:192:26: note: each undeclared identifier is reported only once for each function it appears in drivers/pci/controller/pci-ixp4xx.c:199:1: error: control reaches end of non-void function [-Werror=return-type] 199 | } | ^ cc1: some warnings being treated as errors vim +191 drivers/pci/controller/pci-ixp4xx.c 185 186 static u32 ixp4xx_config_addr(u8 bus_num, u16 devfn, int where) 187 { 188 /* Root bus is always 0 in this hardware */ 189 if (bus_num == 0) { 190 /* type 0 */ > 191 return (PCI_CONF1_ADDRESS(0, 0, PCI_FUNC(devfn), where) & > 192 ~PCI_CONF1_ENABLE) | BIT(32-PCI_SLOT(devfn)); 193 } else { 194 /* type 1 */ 195 return (PCI_CONF1_ADDRESS(bus_num, PCI_SLOT(devfn), 196 PCI_FUNC(devfn), where) & 197 ~PCI_CONF1_ENABLE) | 1; 198 } 199 } 200 -- 0-DAY CI Kernel Test Service https://01.org/lkp