From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1EE4C433F5 for ; Thu, 29 Sep 2022 23:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229437AbiI2XjZ (ORCPT ); Thu, 29 Sep 2022 19:39:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbiI2XjW (ORCPT ); Thu, 29 Sep 2022 19:39:22 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5974D14DAE1 for ; Thu, 29 Sep 2022 16:39:21 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id c24so2551903plo.3 for ; Thu, 29 Sep 2022 16:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=406PHi1E3zQxmMChBF9K8IG+zjCzhZM2d2hHmY4Q4BA=; b=cgJgHsUAGCFMQ3CFDi3AgcrQiOvlEV35DecVLMmwLMl3Mdex18zzkKu24C3g+oYUwQ ukCPFcotbaV/BQzlbkBhRM+bc9mGQ6dyCFZWcSLWR25OPAR8PrOXVwhT+RUET4sjXMF0 nw7RCJvzf1x3Ti9JDeG3d3bCcjISPfBUfs/vU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=406PHi1E3zQxmMChBF9K8IG+zjCzhZM2d2hHmY4Q4BA=; b=12LCx48uN5zN94IVA6Bf2gUievRDrkVGE0aP63apIjo+2QQZetEFtNqKHHkfv4mYcG ASdImgbFtVJ38TL6r3Zqlk7R2nLEXQlu4WXdi/jhRoBvYRrGyAjgDHxOBPRAaQJalFP9 YBipvXBTGCeKtsi/Wj7fUGusabmucR1huoGH+4NLuqfPMn6oypiARR3YkwFBwH8zl9ly 8a2nyquiX0Z2vJ6HnKy2X8/KaM9rM5XFIQ9YW2TgXSe52bw8r5B79ta1CBhkJ9BI7PHL PHCUK4yfzRD778CYSXl7reORFNHebh3uNFSKn8p7DyTVRZh8O11B03PeJO4C7rzEhfzT QPew== X-Gm-Message-State: ACrzQf1+CRn96t3NnQzmS+h61qal764+KpRPm/oB2N3TOTnSw9hqLrlk qfUEGtPSM/24fyzO3Wfvn7Na/RbXqy9VMw== X-Google-Smtp-Source: AMsMyM4zpLGflr4v7oe8USvwOdE1CTEZ8QnadhucyD+2vGwk217VqucBLy0urdyL+4oHeHdsyaYTrg== X-Received: by 2002:a17:902:a606:b0:178:57e4:a0c1 with SMTP id u6-20020a170902a60600b0017857e4a0c1mr5805722plq.83.1664494760865; Thu, 29 Sep 2022 16:39:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s13-20020a17090302cd00b00172dc6e1916sm427601plk.220.2022.09.29.16.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 16:39:20 -0700 (PDT) Date: Thu, 29 Sep 2022 16:39:19 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: Lukas Bulwahn , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct Message-ID: <202209291638.BD0B8639@keescook> References: <20220929203903.9475-1-lukas.bulwahn@gmail.com> <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tu4p3jwn.fsf@email.froward.int.ebiederm.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote: > Lukas Bulwahn writes: > > > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the > > use of the special taso flag for alpha architectures in the linux_binprm > > struct is gone. > > > > Remove the definition of taso in the linux_binprm struct. > > > > No functional change. > > Reviewed-by: "Eric W. Biederman" > > Alphas binfmt_loader is the only use I can find of that variable > so let's kill it as well. Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the only place it was accessed. Agreed. :) -- Kees Cook