Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20220923] url: https://github.com/intel-lab-lkp/linux/commits/zhangsongyi-cgel-gmail-com/scsi-target-use-sysfs_emit-to-instead-of-snprintf/20220927-193709 base: aaa11ce2ffc84166d11c4d2ac88c3fcf75425fbd config: i386-randconfig-a015 compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/df2a8cf8246502fbfbe578ff9f00df9523d1641a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review zhangsongyi-cgel-gmail-com/scsi-target-use-sysfs_emit-to-instead-of-snprintf/20220927-193709 git checkout df2a8cf8246502fbfbe578ff9f00df9523d1641a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/target/iscsi/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/target/iscsi/iscsi_target_stat.c:53:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ^ drivers/target/iscsi/iscsi_target_stat.c:60:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ISCSI_DRAFT20_VERSION); ^ drivers/target/iscsi/iscsi_target_stat.c:66:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ISCSI_DRAFT20_VERSION); ^ drivers/target/iscsi/iscsi_target_stat.c:72:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ^ drivers/target/iscsi/iscsi_target_stat.c:79:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ISCSI_INST_NUM_NODES); ^ drivers/target/iscsi/iscsi_target_stat.c:85:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ^ drivers/target/iscsi/iscsi_target_stat.c:102:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", sess_err_count); ^ drivers/target/iscsi/iscsi_target_stat.c:111:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ^ drivers/target/iscsi/iscsi_target_stat.c:121:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%s\n", ^ drivers/target/iscsi/iscsi_target_stat.c:129:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ISCSI_DISCONTINUITY_TIME); ^ drivers/target/iscsi/iscsi_target_stat.c:135:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%s\n", ISCSI_INST_DESCR); ^ drivers/target/iscsi/iscsi_target_stat.c:141:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "Datera, Inc. iSCSI-Target\n"); ^ drivers/target/iscsi/iscsi_target_stat.c:147:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%s\n", ISCSIT_VERSION); ^ drivers/target/iscsi/iscsi_target_stat.c:199:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ^ drivers/target/iscsi/iscsi_target_stat.c:209:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", sess_err->digest_errors); ^ drivers/target/iscsi/iscsi_target_stat.c:218:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", sess_err->cxn_timeout_errors); ^ drivers/target/iscsi/iscsi_target_stat.c:227:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", sess_err->pdu_format_errors); ^ drivers/target/iscsi/iscsi_target_stat.c:261:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ^ drivers/target/iscsi/iscsi_target_stat.c:268:9: error: implicit declaration of function 'sysfs_emit' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return sysfs_emit(page, "%u\n", ISCSI_NODE_INDEX); ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. vim +/sysfs_emit +53 drivers/target/iscsi/iscsi_target_stat.c 49 50 static ssize_t iscsi_stat_instance_inst_show(struct config_item *item, 51 char *page) 52 { > 53 return sysfs_emit(page, "%u\n", 54 iscsi_instance_tiqn(item)->tiqn_index); 55 } 56 -- 0-DAY CI Kernel Test Service https://01.org/lkp