From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542FDC433F5 for ; Sat, 1 Oct 2022 01:01:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233014AbiJABBn (ORCPT ); Fri, 30 Sep 2022 21:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232898AbiJABAs (ORCPT ); Fri, 30 Sep 2022 21:00:48 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C7AB71BDB for ; Fri, 30 Sep 2022 17:59:58 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-349f88710b2so57220507b3.20 for ; Fri, 30 Sep 2022 17:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date; bh=f70Xbl04urcnggP1iLNXSgd90V7DfOtA4Hkw+IrGqsA=; b=e4uxUpUQ+QYdNoNsX4vjc6+X7Krjind/BXqDg4Mpf0wuclTuUm/UX8PJIBIpwhbdyE 3k8hah7Cj3o8zwn0fmu/X8Whwbjv9wpqeA5/oO2tZZEjMAKFJu0o+cyN/Q4kbu9Ip4Ag jXO1+ddcwdndqBHIDmSaAHoVu5eHb/LZ7GOQzuFCDwsa8KtE1+TFMyWUQGGgoku9bCi5 NLLQ+QqIHKpX7tkSXDjER5jA1BsUXfTbSmaWV8/znmQS1boXEfYGnnR8Rwu+jgt7Tac8 lQIGYQBty3IJiYFTw1IWYFsUrcA0Qz1RRtXI9yzW9WJTlBANcJ4kXL5xfO7wIyonaZWZ JpLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date; bh=f70Xbl04urcnggP1iLNXSgd90V7DfOtA4Hkw+IrGqsA=; b=3Lzv60V/AX66rTPYTyozy+cwnFQ7k9i6DUkGUXPiIzS3xFtvlqc9/NqNKIet7xE2Mq 3wN0I5aQFKtYF8njm7df68xtBSh8b0nX7JmCpohMoaWR4zBylhOe6PwszB+bc4rGOP5A rrBzWn6EYDOz0fpJuoFkvjw+0Xs3k7uEYh5nuqrPKqBsC5NUZthJSzfMUD5pVsTtN6sO 9ajMk9hClas8YoyTrEYpq6uIa6X7DMcq2yYyvGFX87emQTMTB00n/WE9GBOkpel9L4IL Gnjc1ZPj5DDniy/AnGI6DBsjTSBL2RBT5Qzsb3Fp7XcEM26RihD3Lqr4lPSkBimec+ro 3sRg== X-Gm-Message-State: ACrzQf0rc+9Kp9mVJWPQYIWKZs8zPDvP088IS7IvVsTu9Ahoyw944RCP AsFSsJUUDkK9SKs8youyhyQtvU3P6ks= X-Google-Smtp-Source: AMsMyM4lkLby1gHEeOFWlADHcALsYEFrFQWm5GSqcMKQqTBGhNW8SUByosuBg8IDIjuQm/0NpZoRx/Lk644= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1028:b0:6b4:8d06:6b76 with SMTP id x8-20020a056902102800b006b48d066b76mr10610823ybt.182.1664585982678; Fri, 30 Sep 2022 17:59:42 -0700 (PDT) Reply-To: Sean Christopherson Date: Sat, 1 Oct 2022 00:58:57 +0000 In-Reply-To: <20221001005915.2041642-1-seanjc@google.com> Mime-Version: 1.0 References: <20221001005915.2041642-1-seanjc@google.com> X-Mailer: git-send-email 2.38.0.rc1.362.ged0d419d3c-goog Message-ID: <20221001005915.2041642-15-seanjc@google.com> Subject: [PATCH v4 14/32] KVM: SVM: Fix x2APIC Logical ID calculation for avic_kick_target_vcpus_fast From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alejandro Jimenez , Suravee Suthikulpanit , Maxim Levitsky , Li RongQing Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suravee Suthikulpanit For X2APIC ID in cluster mode, the logical ID is bit [15:0]. Fixes: 603ccef42ce9 ("KVM: x86: SVM: fix avic_kick_target_vcpus_fast") Cc: Maxim Levitsky Signed-off-by: Suravee Suthikulpanit Reviewed-by: Maxim Levitsky Signed-off-by: Sean Christopherson --- arch/x86/kvm/svm/avic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c index e9aab8ecce83..e35e9363e7ff 100644 --- a/arch/x86/kvm/svm/avic.c +++ b/arch/x86/kvm/svm/avic.c @@ -356,7 +356,7 @@ static int avic_kick_target_vcpus_fast(struct kvm *kvm, struct kvm_lapic *source if (apic_x2apic_mode(source)) { /* 16 bit dest mask, 16 bit cluster id */ - bitmap = dest & 0xFFFF0000; + bitmap = dest & 0xFFFF; cluster = (dest >> 16) << 4; } else if (kvm_lapic_get_reg(source, APIC_DFR) == APIC_DFR_FLAT) { /* 8 bit dest mask*/ -- 2.38.0.rc1.362.ged0d419d3c-goog