From: Yevhen Orlov <yevhen.orlov@plvision.eu>
To: netdev@vger.kernel.org
Cc: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
Taras Chornyi <taras.chornyi@plvision.eu>,
Mickey Rachamim <mickeyr@marvell.com>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Stephen Hemminger <stephen@networkplumber.org>,
linux-kernel@vger.kernel.org,
Yevhen Orlov <yevhen.orlov@plvision.eu>,
Taras Chornyi <tchornyi@marvell.com>,
Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Subject: [PATCH net-next v7 2/9] net: marvell: prestera: Add cleanup of allocated fib_nodes
Date: Sat, 1 Oct 2022 12:34:10 +0300 [thread overview]
Message-ID: <20221001093417.22388-3-yevhen.orlov@plvision.eu> (raw)
In-Reply-To: <20221001093417.22388-1-yevhen.orlov@plvision.eu>
Do explicity cleanup on router_hw_fini, to ensure, that all allocated
objects cleaned. This will be used in cases,
when upper layer (cache) is not mapped to router_hw layer.
Co-developed-by: Taras Chornyi <tchornyi@marvell.com>
Signed-off-by: Taras Chornyi <tchornyi@marvell.com>
Co-developed-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
---
.../ethernet/marvell/prestera/prestera_router_hw.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c b/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c
index db9d2e9d9904..4f65df0ae5e8 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_router_hw.c
@@ -56,6 +56,7 @@ static int prestera_nexthop_group_set(struct prestera_switch *sw,
static bool
prestera_nexthop_group_util_hw_state(struct prestera_switch *sw,
struct prestera_nexthop_group *nh_grp);
+static void prestera_fib_node_destroy_ht_cb(void *ptr, void *arg);
/* TODO: move to router.h as macros */
static bool prestera_nh_neigh_key_is_valid(struct prestera_nh_neigh_key *key)
@@ -97,6 +98,8 @@ int prestera_router_hw_init(struct prestera_switch *sw)
void prestera_router_hw_fini(struct prestera_switch *sw)
{
+ rhashtable_free_and_destroy(&sw->router->fib_ht,
+ prestera_fib_node_destroy_ht_cb, sw);
WARN_ON(!list_empty(&sw->router->vr_list));
WARN_ON(!list_empty(&sw->router->rif_entry_list));
rhashtable_destroy(&sw->router->fib_ht);
@@ -605,6 +608,15 @@ void prestera_fib_node_destroy(struct prestera_switch *sw,
kfree(fib_node);
}
+static void prestera_fib_node_destroy_ht_cb(void *ptr, void *arg)
+{
+ struct prestera_fib_node *node = ptr;
+ struct prestera_switch *sw = arg;
+
+ __prestera_fib_node_destruct(sw, node);
+ kfree(node);
+}
+
struct prestera_fib_node *
prestera_fib_node_create(struct prestera_switch *sw,
struct prestera_fib_key *key,
--
2.17.1
next prev parent reply other threads:[~2022-10-01 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 9:34 [PATCH net-next v7 0/9] net: marvell: prestera: add nexthop routes offloading Yevhen Orlov
2022-10-01 9:34 ` [PATCH net-next v7 1/9] net: marvell: prestera: Add router nexthops ABI Yevhen Orlov
2022-10-01 9:34 ` Yevhen Orlov [this message]
2022-10-01 9:34 ` [PATCH net-next v7 3/9] net: marvell: prestera: Add strict cleanup of fib arbiter Yevhen Orlov
2022-10-01 9:34 ` [PATCH net-next v7 4/9] net: marvell: prestera: add delayed wq and flush wq on deinit Yevhen Orlov
2022-10-01 9:34 ` [PATCH net-next v7 5/9] net: marvell: prestera: Add length macros for prestera_ip_addr Yevhen Orlov
2022-10-01 9:34 ` [PATCH net-next v7 6/9] net: marvell: prestera: Add heplers to interact with fib_notifier_info Yevhen Orlov
2022-10-01 9:34 ` [PATCH net-next v7 7/9] net: marvell: prestera: add stub handler neighbour events Yevhen Orlov
2022-10-01 9:34 ` [PATCH net-next v7 8/9] net: marvell: prestera: Add neighbour cache accounting Yevhen Orlov
2022-10-01 9:34 ` [PATCH net-next v7 9/9] net: marvell: prestera: Propagate nh state from hw to kernel Yevhen Orlov
2022-10-04 0:25 ` [PATCH net-next v7 0/9] net: marvell: prestera: add nexthop routes offloading patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221001093417.22388-3-yevhen.orlov@plvision.eu \
--to=yevhen.orlov@plvision.eu \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=pabeni@redhat.com \
--cc=serhiy.pshyk@plvision.eu \
--cc=stephen@networkplumber.org \
--cc=taras.chornyi@plvision.eu \
--cc=tchornyi@marvell.com \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®