tree: https://github.com/AsahiLinux/linux bits/120-spmi head: 5cb4da8579049c7a25e3369dc81388c4a647d4ca commit: 5cb4da8579049c7a25e3369dc81388c4a647d4ca [6/6] spmi: apple: Properly wait for status data after write config: microblaze-allyesconfig compiler: microblaze-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/AsahiLinux/linux/commit/5cb4da8579049c7a25e3369dc81388c4a647d4ca git remote add asahilinux https://github.com/AsahiLinux/linux git fetch --no-tags asahilinux bits/120-spmi git checkout 5cb4da8579049c7a25e3369dc81388c4a647d4ca # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/net/can/ drivers/net/ethernet/hisilicon/hns3/ drivers/net/ethernet/mellanox/mlx5/core/ drivers/net/ethernet/microchip/sparx5/ drivers/spmi/ sound/soc/mediatek/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/spmi/spmi-apple-controller.c: In function 'spmi_write_cmd': >> drivers/spmi/spmi-apple-controller.c:98:22: warning: variable 'rsp' set but not used [-Wunused-but-set-variable] 98 | volatile u32 rsp; | ^~~ vim +/rsp +98 drivers/spmi/spmi-apple-controller.c 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 92 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 93 static int spmi_write_cmd(struct spmi_controller *ctrl, 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 94 u8 opc, u8 slave_id, u16 slave_addr, const u8 *__buf, size_t bc) 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 95 { 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 96 struct apple_spmi *spmi; 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 97 u32 spmi_cmd = opc|slave_id<<8|slave_addr<<16|(bc-1)|(1<<15); 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 @98 volatile u32 rsp; 5cb4da8579049c Hector Martin 2022-07-02 99 volatile u32 status; 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 100 size_t i=0,j; 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 101 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 102 spmi = spmi_controller_get_drvdata(ctrl); 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 103 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 104 write_reg(spmi_cmd, spmi, SPMI_CMD_REG); 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 105 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 106 while (i=5){ 5cb4da8579049c Hector Martin 2022-07-02 125 dev_err(&ctrl->dev,"spmi_write_cmd:took to long to get the status"); 5cb4da8579049c Hector Martin 2022-07-02 126 return -1; 5cb4da8579049c Hector Martin 2022-07-02 127 } 5cb4da8579049c Hector Martin 2022-07-02 128 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 129 rsp = read_reg(spmi, SPMI_RSP_REG); 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 130 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 131 return 0; 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 132 } 284819edc1f472 Jean-Francois Bortolotti 2022-02-04 133 :::::: The code at line 98 was first introduced by commit :::::: 284819edc1f472c7f4d4a7164a388abb639f719c spmi: add a first basic spmi driver for Apple SoC :::::: TO: Jean-Francois Bortolotti :::::: CC: Hector Martin -- 0-DAY CI Kernel Test Service https://01.org/lkp