From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F596C433FE for ; Tue, 4 Oct 2022 15:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229522AbiJDP3s (ORCPT ); Tue, 4 Oct 2022 11:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbiJDP3k (ORCPT ); Tue, 4 Oct 2022 11:29:40 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EEA1B60 for ; Tue, 4 Oct 2022 08:29:39 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id z20so6439687plb.10 for ; Tue, 04 Oct 2022 08:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=nUL++0YrOYbJH41lSNmtuJxacmngBwCLovlOvSL11Ig=; b=ulsx/+XspxWuKPRcjNEAJd2ZO+D5ZkL81pDBqHkyEnvxo/b+WtFVCTCkGdEOLCbv71 3+6TvnN/Ijg0UMtzwYMglPeeBcLFOSqglCT5yhBBfZ0uSnfdUM7f4n4bPFqR5xo5JTkM DsKVf/xWua2m/9BpE9subFfd4Tw/JCuMzzkhxVLBUBRzBeibJYzqAkw8mMaQ8MyJRWQK 3rspifJH8Jf2iwsnUEtAa+zyhvkTteWqPjHbnP3E7qB+0QLzLjfuz8ha8ULHKmG5UjZY fz45gQN7a/ZuNBvS2hVXe7HxjRijdTH6dU3uLqEC+L07VPC0q6ErtpS1ZrgmSPtcR9lU a4tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=nUL++0YrOYbJH41lSNmtuJxacmngBwCLovlOvSL11Ig=; b=nMXyfoCWuShhyf/Vk783Gs/ohTd8PQ//s3PaDD3+2UL2A0b8fvm0ZD+FbL7adCaXLN JW1A8yf/d10+NY08Ian3sou3i4ZLv4nyWtm7qX17aASKaOroyuQsge/PVpD1ADCsKQ7r n+NHRXbopECTV9tlx73g/7Z0yolWfLOBxjsI1WOIZPKQU6nxZZ0XFISOvqKTe4UpYuIl Lfe2EDL5Vq11j20h2IwsdecRoiRhdElXDc5eP3AuvLb8YSo52vbphOKVzRuTfdmNahzG pEfhUuPxcGA9Qb01MpN6nEJcixkEE8L8NRdDC8awK1vgW8LJ1rz3eoT+BVS4CGxozfH8 30vg== X-Gm-Message-State: ACrzQf1rEpxc2c2sXINUtYb0XVsdMVz1PvW2wnwWD7Pjk6r/RLJ+hJLd F5uZetrmU9MDqjnlaWqydgVf4w== X-Google-Smtp-Source: AMsMyM6tSkfKGnSMw+t++Suvs7KT14XyVMsN2c8nid0Q9jzlfgmlAuLvTLOohKpnN20t8Zx9Aie7XQ== X-Received: by 2002:a17:90b:4c8b:b0:203:5db5:8b71 with SMTP id my11-20020a17090b4c8b00b002035db58b71mr280183pjb.51.1664897378665; Tue, 04 Oct 2022 08:29:38 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id px9-20020a17090b270900b002009db534d1sm8158299pjb.24.2022.10.04.08.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 08:29:38 -0700 (PDT) Date: Tue, 4 Oct 2022 08:29:36 -0700 From: Stephen Hemminger To: Peter Kosyh Cc: Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ instead hardcoded constant. Message-ID: <20221004082936.0d0c9bcb@hermes.local> In-Reply-To: <20221004095034.377665-1-pkosyh@yandex.ru> References: <20221004095034.377665-1-pkosyh@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Oct 2022 12:50:34 +0300 Peter Kosyh wrote: > printf to array 'eqo->desc' of size 32 may cause buffer overflow when > using non-standard IFNAMSIZ. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Peter Kosyh NACK Non-standard IFNAMSIZ will break uapi and many things. I see no reason for kernel or tools like iproute2 to support or fix those related bugs.