Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on brgl/gpio/for-next] [also build test ERROR on linus/master v6.0 next-20221004] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/gpiolib-Get-rid-of-not-used-of_node-member/20221004-183204 base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next config: hexagon-randconfig-r024-20221003 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/e0bc05e674d1be3d05351ec364768345f563b243 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/gpiolib-Get-rid-of-not-used-of_node-member/20221004-183204 git checkout e0bc05e674d1be3d05351ec364768345f563b243 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/pinctrl/actions/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/pinctrl/actions/pinctrl-owl.c:878:31: error: no member named 'of_node' in 'struct gpio_chip' pctrl->irq_chip.name = chip->of_node->name; ~~~~ ^ 1 error generated. vim +878 drivers/pinctrl/actions/pinctrl-owl.c 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 864 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 865 static int owl_gpio_init(struct owl_pinctrl *pctrl) 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 866 { 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 867 struct gpio_chip *chip; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 868 struct gpio_irq_chip *gpio_irq; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 869 int ret, i, j, offset; 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 870 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 871 chip = &pctrl->chip; 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 872 chip->base = -1; 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 873 chip->ngpio = pctrl->soc->ngpios; 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 874 chip->label = dev_name(pctrl->dev); 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 875 chip->parent = pctrl->dev; 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 876 chip->owner = THIS_MODULE; 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 877 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 @878 pctrl->irq_chip.name = chip->of_node->name; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 879 pctrl->irq_chip.irq_ack = owl_gpio_irq_ack; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 880 pctrl->irq_chip.irq_mask = owl_gpio_irq_mask; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 881 pctrl->irq_chip.irq_unmask = owl_gpio_irq_unmask; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 882 pctrl->irq_chip.irq_set_type = owl_gpio_irq_set_type; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 883 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 884 gpio_irq = &chip->irq; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 885 gpio_irq->chip = &pctrl->irq_chip; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 886 gpio_irq->handler = handle_simple_irq; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 887 gpio_irq->default_type = IRQ_TYPE_NONE; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 888 gpio_irq->parent_handler = owl_gpio_irq_handler; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 889 gpio_irq->parent_handler_data = pctrl; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 890 gpio_irq->num_parents = pctrl->num_irq; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 891 gpio_irq->parents = pctrl->irq; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 892 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 893 gpio_irq->map = devm_kcalloc(pctrl->dev, chip->ngpio, 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 894 sizeof(*gpio_irq->map), GFP_KERNEL); 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 895 if (!gpio_irq->map) 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 896 return -ENOMEM; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 897 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 898 for (i = 0, offset = 0; i < pctrl->soc->nports; i++) { 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 899 const struct owl_gpio_port *port = &pctrl->soc->ports[i]; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 900 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 901 for (j = 0; j < port->pins; j++) 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 902 gpio_irq->map[offset + j] = gpio_irq->parents[i]; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 903 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 904 offset += port->pins; 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 905 } 6c5d0736e9c09f Manivannan Sadhasivam 2018-06-23 906 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 907 ret = gpiochip_add_data(&pctrl->chip, pctrl); 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 908 if (ret) { 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 909 dev_err(pctrl->dev, "failed to register gpiochip\n"); 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 910 return ret; 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 911 } 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 912 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 913 return 0; 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 914 } 33257f860a13d8 Manivannan Sadhasivam 2018-05-20 915 -- 0-DAY CI Kernel Test Service https://01.org/lkp