From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ross Zwisler <zwisler@kernel.org>
Subject: Re: [PATCH] tracing: Do not free snapshot if tracer is on cmdline
Date: Wed, 5 Oct 2022 09:53:05 -0400 [thread overview]
Message-ID: <20221005095305.707ec79b@gandalf.local.home> (raw)
In-Reply-To: <20221005220856.d2c2db5a499a79874f0c96e3@kernel.org>
On Wed, 5 Oct 2022 22:08:56 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> Looks good to me.
>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
Unfortunately, this is causing a failure in one of my tests. I'm still
trying to figure out how it is an issue.
-- Steve
>
> > ---
> > kernel/trace/trace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index def721de68a0..871e2b592969 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -6432,7 +6432,7 @@ int tracing_set_tracer(struct trace_array *tr, const char *buf)
> > tr->current_trace = &nop_trace;
> >
> > #ifdef CONFIG_TRACER_MAX_TRACE
> > - had_max_tr = tr->allocated_snapshot;
> > + had_max_tr = tr->current_trace->use_max_tr;
> >
> > if (had_max_tr && !t->use_max_tr) {
> > /*
prev parent reply other threads:[~2022-10-05 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 22:04 Steven Rostedt
2022-10-05 13:08 ` Masami Hiramatsu
2022-10-05 13:53 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221005095305.707ec79b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®