Hi Paolo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on linus/master v6.0 next-20221005] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Paolo-Valente/block-bfq-extend-bfq-to-support-multi-actuator-drives/20221004-174503 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: i386-randconfig-m021-20221003 compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot New smatch warnings: block/bfq-iosched.c:7009 bfq_put_async_queues() warn: inconsistent indenting Old smatch warnings: block/bfq-iosched.c:6133 __bfq_insert_request() warn: variable dereferenced before check 'bfqq' (see line 6129) vim +7009 block/bfq-iosched.c 6993 6994 /* 6995 * Release all the bfqg references to its async queues. If we are 6996 * deallocating the group these queues may still contain requests, so 6997 * we reparent them to the root cgroup (i.e., the only one that will 6998 * exist for sure until all the requests on a device are gone). 6999 */ 7000 void bfq_put_async_queues(struct bfq_data *bfqd, struct bfq_group *bfqg) 7001 { 7002 int i, j, k; 7003 7004 for (k = 0; k < BFQ_NUM_ACTUATORS; k++) { 7005 for (i = 0; i < 2; i++) 7006 for (j = 0; j < IOPRIO_NR_LEVELS; j++) 7007 __bfq_put_async_bfqq(bfqd, &bfqg->async_bfqq[i][j][k]); 7008 > 7009 __bfq_put_async_bfqq(bfqd, &bfqg->async_idle_bfqq[k]); 7010 } 7011 } 7012 -- 0-DAY CI Kernel Test Service https://01.org/lkp