Hi Nick, I love your patch! Yet something to improve: [auto build test ERROR on 833477fce7a14d43ae4c07f8ddc32fa5119471a2] url: https://github.com/intel-lab-lkp/linux/commits/Nick-Desaulniers/overflow-disable-failing-tests-for-older-clang-versions/20221006-062232 base: 833477fce7a14d43ae4c07f8ddc32fa5119471a2 config: hexagon-randconfig-r041-20221003 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/cf7d44fb2c24fbc5424fb6f17095eead3cbe5b92 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Nick-Desaulniers/overflow-disable-failing-tests-for-older-clang-versions/20221006-062232 git checkout cf7d44fb2c24fbc5424fb6f17095eead3cbe5b92 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> lib/overflow_kunit.c:723:13: error: use of undeclared identifier 'u64_u64__u64_overflow_test' KUNIT_CASE(u64_u64__u64_overflow_test), ^ >> lib/overflow_kunit.c:724:13: error: use of undeclared identifier 's64_s64__s64_overflow_test' KUNIT_CASE(s64_s64__s64_overflow_test), ^ 2 errors generated. vim +/u64_u64__u64_overflow_test +723 lib/overflow_kunit.c e1be43d9b5d0d13 lib/test_overflow.c Kees Cook 2021-09-18 711 617f55e20743fc5 lib/overflow_kunit.c Kees Cook 2022-02-16 712 static struct kunit_case overflow_test_cases[] = { d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 713 KUNIT_CASE(u8_u8__u8_overflow_test), d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 714 KUNIT_CASE(s8_s8__s8_overflow_test), d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 715 KUNIT_CASE(u16_u16__u16_overflow_test), d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 716 KUNIT_CASE(s16_s16__s16_overflow_test), d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 717 KUNIT_CASE(u32_u32__u32_overflow_test), d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 718 KUNIT_CASE(s32_s32__s32_overflow_test), 6a022dd29f2cefb lib/overflow_kunit.c Kees Cook 2022-05-11 719 /* Clang 13 and earlier generate unwanted libcalls on 32-bit. */ cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 720 #if defined(CONFIG_CC_IS_GCC) || \ cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 721 (defined(CONFIG_CC_IS_CLANG) && \ cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 722 (__clang_major__ > 13 || BITS_PER_LONG == 64)) d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 @723 KUNIT_CASE(u64_u64__u64_overflow_test), d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 @724 KUNIT_CASE(s64_s64__s64_overflow_test), 617f55e20743fc5 lib/overflow_kunit.c Kees Cook 2022-02-16 725 #endif cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 726 /* cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 727 * Clang 11 and earlier generate unwanted libcalls for signed output, unsigned cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 728 * input. cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 729 * https://github.com/llvm/llvm-project/commit/3203143f1356a4e4e3ada231156fc6da6e1a9f9d cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 730 */ cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 731 #if defined(CONFIG_CC_IS_GCC) || \ cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 732 (defined(CONFIG_CC_IS_CLANG) && \ cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 733 (__clang_major__ > 11 || BITS_PER_LONG == 64)) d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 734 KUNIT_CASE(u32_u32__int_overflow_test), cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 735 #endif cf7d44fb2c24fbc lib/overflow_kunit.c Nick Desaulniers 2022-10-05 736 KUNIT_CASE(u32_u32__u8_overflow_test), d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 737 KUNIT_CASE(u8_u8__int_overflow_test), d219d2a9a92e39a lib/overflow_kunit.c Kees Cook 2022-08-29 738 KUNIT_CASE(int_int__u8_overflow_test), 779742255cb464e lib/overflow_kunit.c Kees Cook 2022-08-31 739 KUNIT_CASE(shift_sane_test), 779742255cb464e lib/overflow_kunit.c Kees Cook 2022-08-31 740 KUNIT_CASE(shift_overflow_test), 779742255cb464e lib/overflow_kunit.c Kees Cook 2022-08-31 741 KUNIT_CASE(shift_truncate_test), 779742255cb464e lib/overflow_kunit.c Kees Cook 2022-08-31 742 KUNIT_CASE(shift_nonsense_test), 617f55e20743fc5 lib/overflow_kunit.c Kees Cook 2022-02-16 743 KUNIT_CASE(overflow_allocation_test), 617f55e20743fc5 lib/overflow_kunit.c Kees Cook 2022-02-16 744 KUNIT_CASE(overflow_size_helpers_test), 617f55e20743fc5 lib/overflow_kunit.c Kees Cook 2022-02-16 745 {} 617f55e20743fc5 lib/overflow_kunit.c Kees Cook 2022-02-16 746 }; 455a35a6cdb6f53 lib/test_overflow.c Rasmus Villemoes 2018-05-08 747 -- 0-DAY CI Kernel Test Service https://01.org/lkp