Hi chengwei, Thank you for the patch! Yet something to improve: [auto build test ERROR on 4fe89d07dcc2804c8b562f6c7896a45643d34b2f] url: https://github.com/intel-lab-lkp/linux/commits/chengwei/Add-support-control-UP-board-CPLD-onboard-LEDS/20221007-133049 base: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f config: arm64-randconfig-r006-20221007 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/d3a9f6dc10e220b5128657fa8039bd4c0d9a2a31 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review chengwei/Add-support-control-UP-board-CPLD-onboard-LEDS/20221007-133049 git checkout d3a9f6dc10e220b5128657fa8039bd4c0d9a2a31 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash ./ drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/mfd/upboard-fpga.c:390:11: error: call to undeclared function 'acpi_evaluate_integer'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv); ^ drivers/mfd/upboard-fpga.c:390:11: note: did you mean 'acpi_evaluate_object'? include/acpi/acpixf.h:550:8: note: 'acpi_evaluate_object' declared here acpi_evaluate_object(acpi_handle object, ^ include/acpi/platform/aclinux.h:93:21: note: expanded from macro 'ACPI_EXTERNAL_RETURN_STATUS' static ACPI_INLINE prototype {return(AE_NOT_CONFIGURED);} ^ 1 error generated. vim +/acpi_evaluate_integer +390 drivers/mfd/upboard-fpga.c 372 373 static int __init upboard_fpga_probe(struct platform_device *pdev) 374 { 375 struct upboard_fpga *fpga; 376 const struct acpi_device_id *id; 377 const struct upboard_fpga_data *fpga_data; 378 const struct dmi_system_id *system_id; 379 acpi_handle handle; 380 acpi_status status; 381 unsigned long long hrv; 382 unsigned long quirks = 0; 383 int ret; 384 385 id = acpi_match_device(upboard_fpga_acpi_match, &pdev->dev); 386 if (!id) 387 return -ENODEV; 388 389 handle = ACPI_HANDLE(&pdev->dev); > 390 status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv); 391 if (ACPI_FAILURE(status)) { 392 dev_err(&pdev->dev, "failed to get PCTL revision"); 393 return -ENODEV; 394 } 395 396 system_id = dmi_first_match(upboard_dmi_table); 397 if (system_id) 398 quirks = (unsigned long)system_id->driver_data; 399 400 if (hrv == 1 && (quirks & UPFPGA_QUIRK_HRV1_IS_PROTO2)) 401 hrv = UPFPGA_PROTOCOL_V2_HRV; 402 403 if (hrv != UPFPGA_PROTOCOL_V2_HRV) { 404 dev_dbg(&pdev->dev, "unsupported PCTL revision: %llu", hrv); 405 return -ENODEV; 406 } 407 408 fpga_data = (const struct upboard_fpga_data *) id->driver_data; 409 410 fpga = devm_kzalloc(&pdev->dev, sizeof(*fpga), GFP_KERNEL); 411 if (!fpga) 412 return -ENOMEM; 413 414 if (quirks & UPFPGA_QUIRK_UNINITIALISED) { 415 dev_info(&pdev->dev, "FPGA not initialised by this BIOS"); 416 fpga->uninitialised = true; 417 } 418 419 dev_set_drvdata(&pdev->dev, fpga); 420 fpga->dev = &pdev->dev; 421 fpga->regmap = devm_regmap_init(&pdev->dev, NULL, fpga, 422 fpga_data->regmapconf); 423 if (IS_ERR(fpga->regmap)) 424 return PTR_ERR(fpga->regmap); 425 426 ret = upboard_fpga_gpio_init(fpga); 427 if (ret) { 428 dev_err(&pdev->dev, "failed to init FPGA comm GPIOs: %d", ret); 429 return ret; 430 } 431 432 ret = upboard_fpga_detect_firmware(fpga); 433 if (ret) 434 return ret; 435 436 if (quirks & UPFPGA_QUIRK_GPIO_LED) { 437 #define APL_GPIO_218 507 438 static struct gpio_led upboard_gpio_leds[] = { 439 { 440 .name = "upboard:blue:", 441 .gpio = APL_GPIO_218, 442 .default_state = LEDS_GPIO_DEFSTATE_KEEP, 443 }, 444 }; 445 static struct gpio_led_platform_data upboard_gpio_led_platform_data = { 446 .num_leds = ARRAY_SIZE(upboard_gpio_leds), 447 .leds = upboard_gpio_leds, 448 }; 449 static const struct mfd_cell upboard_gpio_led_cells[] = { 450 { 451 .name = "leds-gpio", 452 .id = 0, 453 .platform_data = &upboard_gpio_led_platform_data, 454 .pdata_size = sizeof(upboard_gpio_led_platform_data), 455 }, 456 }; 457 458 ret = devm_mfd_add_devices(&pdev->dev, 0, upboard_gpio_led_cells, 459 ARRAY_SIZE(upboard_gpio_led_cells), NULL, 0, NULL); 460 if (ret) { 461 dev_err(&pdev->dev, "Failed to add GPIO leds"); 462 return ret; 463 } 464 465 } 466 467 return devm_mfd_add_devices(&pdev->dev, 0, fpga_data->cells, 468 fpga_data->ncells, NULL, 0, NULL); 469 } 470 -- 0-DAY CI Kernel Test Service https://01.org/lkp