From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1E8C4332F for ; Sun, 9 Oct 2022 23:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231392AbiJIXxP (ORCPT ); Sun, 9 Oct 2022 19:53:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231287AbiJIXwT (ORCPT ); Sun, 9 Oct 2022 19:52:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340B3B480; Sun, 9 Oct 2022 16:23:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D0EF60DD3; Sun, 9 Oct 2022 22:26:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4C9CC433C1; Sun, 9 Oct 2022 22:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665354409; bh=EbU2D14YWvPinVtMGrICilq6H1ntewZavwG99uxHGi4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZB+EoUxcBX4N+vgKz+K28BZHio+J3rSS+vJZPKGILbUWrv7Vo/nmy/OrdDIr0hyBy +uieUmFKcon86dwxQ9K1Q3Asoh7IDyb8R4z5p4xvZsGDdgc154Dumf7egvTkJfp+bG xQ+pWZQrTlTbGvq2nHrF7p8uogcmWVDDoAKiR3AwP4bK46BzGsmQuwqDtu0R70azm4 Nh7eV+F1CrrmoDRUOk5qtrIefrLF5/if4YLeE/xw1kQPaj00q8x9dQudsw+DFCIN70 PAwSCKgkXTC+cIWkc3z3MYtQ2OM4H8yeX9AC4hzqek6kXu5hQPq65/btqNP3yn6Kg3 tOdZMXzJMxo0g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nathan Huckleberry , Dan Carpenter , llvm@lists.linux.dev, Nathan Chancellor , Jakub Kicinski , Sasha Levin , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, ndesaulniers@google.com, thomas.lendacky@amd.com, petrm@nvidia.com, mw@semihalf.com, geoff@infradead.org, wsa+renesas@sang-engineering.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 14/23] net: korina: Fix return type of korina_send_packet Date: Sun, 9 Oct 2022 18:25:44 -0400 Message-Id: <20221009222557.1219968-14-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221009222557.1219968-1-sashal@kernel.org> References: <20221009222557.1219968-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Huckleberry [ Upstream commit 106c67ce46f3c82dd276e983668a91d6ed631173 ] The ndo_start_xmit field in net_device_ops is expected to be of type netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev). The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition. The return type of korina_send_packet should be changed from int to netdev_tx_t. Reported-by: Dan Carpenter Link: https://github.com/ClangBuiltLinux/linux/issues/1703 Cc: llvm@lists.linux.dev Signed-off-by: Nathan Huckleberry Reviewed-by: Nathan Chancellor Link: https://lore.kernel.org/r/20220912214344.928925-1-nhuck@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/korina.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index ec1c14e3eace..09e3e516ded3 100644 --- a/drivers/net/ethernet/korina.c +++ b/drivers/net/ethernet/korina.c @@ -193,7 +193,8 @@ static void korina_chain_rx(struct korina_private *lp, } /* transmit packet */ -static int korina_send_packet(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t korina_send_packet(struct sk_buff *skb, + struct net_device *dev) { struct korina_private *lp = netdev_priv(dev); unsigned long flags; -- 2.35.1