From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6554AC433FE for ; Sun, 9 Oct 2022 23:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230449AbiJIXwG (ORCPT ); Sun, 9 Oct 2022 19:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231216AbiJIXvk (ORCPT ); Sun, 9 Oct 2022 19:51:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1237961725; Sun, 9 Oct 2022 16:22:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8842260DC8; Sun, 9 Oct 2022 22:26:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9F52C43153; Sun, 9 Oct 2022 22:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665354412; bh=g7jL3VwSFDP45ZHiaaVV5tuoAna1OHEHuXqpaCKJgWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wklw6ePoOeyyy9pcJL8G3GNf7x9AAqaAKr+Gq98vvjfRFNwiYCBB8gbKWDV5Sh6dv tmPr2eHIiWqJC3MkC54bAy1IN0E3cedal8xqeqcrWetGloI1ADPSMGfF73tmGt5Ul+ GYCa/dS2OGcdVCuB9UkaqS2TN3JizpfLaVSPFZQ4elGUQLLZ1rHKwIbKyD2LAY/4hq iNZRNaxs8JnRlErlOO63I3XLjUekYJG/ZaWc5X/zM4zT9vXseWqSryMGLHdhQ8rAd4 ipy7Kmrpe2dvCm94tW1rm3MJNtmIGAN+G2WAAkCCjJ6hA6YbKNQ6Pxuh9/AiLCvJK5 pnNn6lwICpDfw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ziyang Xuan , Marc Kleine-Budde , Oliver Hartkopp , Sasha Levin , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 16/23] can: bcm: check the result of can_send() in bcm_can_tx() Date: Sun, 9 Oct 2022 18:25:46 -0400 Message-Id: <20221009222557.1219968-16-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221009222557.1219968-1-sashal@kernel.org> References: <20221009222557.1219968-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ziyang Xuan [ Upstream commit 3fd7bfd28cfd68ae80a2fe92ea1615722cc2ee6e ] If can_send() fail, it should not update frames_abs counter in bcm_can_tx(). Add the result check for can_send() in bcm_can_tx(). Suggested-by: Marc Kleine-Budde Suggested-by: Oliver Hartkopp Signed-off-by: Ziyang Xuan Link: https://lore.kernel.org/all/9851878e74d6d37aee2f1ee76d68361a46f89458.1663206163.git.william.xuanziyang@huawei.com Acked-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- net/can/bcm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index b3f3b02ffd42..89b955ef75d1 100644 --- a/net/can/bcm.c +++ b/net/can/bcm.c @@ -286,6 +286,7 @@ static void bcm_can_tx(struct bcm_op *op) struct sk_buff *skb; struct net_device *dev; struct canfd_frame *cf = op->frames + op->cfsiz * op->currframe; + int err; /* no target device? => exit */ if (!op->ifindex) @@ -310,11 +311,11 @@ static void bcm_can_tx(struct bcm_op *op) /* send with loopback */ skb->dev = dev; can_skb_set_owner(skb, op->sk); - can_send(skb, 1); + err = can_send(skb, 1); + if (!err) + op->frames_abs++; - /* update statistics */ op->currframe++; - op->frames_abs++; /* reached last frame? */ if (op->currframe >= op->nframes) -- 2.35.1