From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D433C433F5 for ; Sun, 9 Oct 2022 23:13:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233483AbiJIXNP (ORCPT ); Sun, 9 Oct 2022 19:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233459AbiJIXMq (ORCPT ); Sun, 9 Oct 2022 19:12:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B03656B9D; Sun, 9 Oct 2022 15:38:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 987A460DC6; Sun, 9 Oct 2022 22:27:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 796CCC433C1; Sun, 9 Oct 2022 22:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665354459; bh=Lq9ysN62kmmqREsBCAGoWQION8SZVICjoEzd7syGdKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MSYlWfOQaQEgVf0mK+ZlntV77YFWnWrSpOjtp0Mgc4RehKfkMVFp4Tj8boFh3DZj2 cyUP4a/KZQFcz529fBHCH8Cbvhis5DGNGoNK0xh/L2pMvweE63WPjWV+SXC/RQF4SB YpsIFtuefAmuqKHCk6q5HWU9RA/d4X+2D0rXtkedDfMpjoyp9iHogkmHnlYK2qv7iq 8JJJtwAAZ0bKOKGbLboM8YTu2dIIxRAuX1zLdpUmL1/xGLMROx+1hmE1OXOTLRNE4g P/Q4c1q2vdBIFjkcTFVCRA2yvo/hEa2Po0sPYF6/uc2sszrpCw2GhsGsWPlYck9sh/ WIuN4ftDXYj4Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nathan Huckleberry , Dan Carpenter , llvm@lists.linux.dev, Nathan Chancellor , Jakub Kicinski , Sasha Levin , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, ndesaulniers@google.com, petrm@nvidia.com, thomas.lendacky@amd.com, wsa+renesas@sang-engineering.com, dmitry.torokhov@gmail.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 09/16] net: davicom: Fix return type of dm9000_start_xmit Date: Sun, 9 Oct 2022 18:27:05 -0400 Message-Id: <20221009222713.1220394-9-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221009222713.1220394-1-sashal@kernel.org> References: <20221009222713.1220394-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Huckleberry [ Upstream commit 0191580b000d50089a0b351f7cdbec4866e3d0d2 ] The ndo_start_xmit field in net_device_ops is expected to be of type netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev). The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition. The return type of dm9000_start_xmit should be changed from int to netdev_tx_t. Reported-by: Dan Carpenter Link: https://github.com/ClangBuiltLinux/linux/issues/1703 Cc: llvm@lists.linux.dev Signed-off-by: Nathan Huckleberry Reviewed-by: Nathan Chancellor Link: https://lore.kernel.org/r/20220912194722.809525-1-nhuck@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/davicom/dm9000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index 0fe4d8999823..59e09f7174c1 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c @@ -1023,7 +1023,7 @@ static void dm9000_send_packet(struct net_device *dev, * Hardware start transmission. * Send a packet to media from the upper layer. */ -static int +static netdev_tx_t dm9000_start_xmit(struct sk_buff *skb, struct net_device *dev) { unsigned long flags; -- 2.35.1