Hi Elliot,

I love your patch! Yet something to improve:

[auto build test ERROR on 4fe89d07dcc2804c8b562f6c7896a45643d34b2f]

url:    https://github.com/intel-lab-lkp/linux/commits/Elliot-Berman/Drivers-for-gunyah-hypervisor/20221011-081934
base:   4fe89d07dcc2804c8b562f6c7896a45643d34b2f
config: arm64-allyesconfig
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/959054eb26b8711586a7835aadc3795b77e9a694
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Elliot-Berman/Drivers-for-gunyah-hypervisor/20221011-081934
        git checkout 959054eb26b8711586a7835aadc3795b77e9a694
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/tty/gunyah_console.c:422:40: error: array type has incomplete element type 'struct gunyah_rm_cons_device_id'
     422 | static struct gunyah_rm_cons_device_id rm_cons_console_ids[] = {
         |                                        ^~~~~~~~~~~~~~~~~~~
   drivers/tty/gunyah_console.c:422:40: warning: 'rm_cons_console_ids' defined but not used [-Wunused-variable]


vim +422 drivers/tty/gunyah_console.c

   421	
 > 422	static struct gunyah_rm_cons_device_id rm_cons_console_ids[] = {
   423		{ .name = GH_RM_DEVICE_CONSOLE },
   424		{}
   425	};
   426	MODULE_DEVICE_TABLE(gunyah_rsc_mgr, rm_cons_console_ids);
   427	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp