From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB09C433FE for ; Wed, 12 Oct 2022 11:12:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbiJLLM0 (ORCPT ); Wed, 12 Oct 2022 07:12:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229703AbiJLLMW (ORCPT ); Wed, 12 Oct 2022 07:12:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D393CC148A; Wed, 12 Oct 2022 04:12:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D4E7614AC; Wed, 12 Oct 2022 11:12:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66033C433D6; Wed, 12 Oct 2022 11:12:17 +0000 (UTC) Date: Wed, 12 Oct 2022 07:12:16 -0400 From: Steven Rostedt To: Sven Schnelle Cc: Ingo Molnar , Shuah Khan , "Masami Hiramatsu (Google)" , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Shuah Khan Subject: Re: [PATCH] selftests/ftrace: fix dynamic_events dependency check Message-ID: <20221012071216.1a74cc21@rorschach.local.home> In-Reply-To: <20221010074207.714077-1-svens@linux.ibm.com> References: <20221010074207.714077-1-svens@linux.ibm.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Oct 2022 09:42:07 +0200 Sven Schnelle wrote: > commit 95c104c378dc ("tracing: Auto generate event name when creating a > group of events") changed the syntax in the ftrace README file which is > used by the selftests to check what features are support. Adjust the > string to make test_duplicates.tc and trigger-synthetic-eprobe.tc work > again. > > Fixes: 95c104c378dc ("tracing: Auto generate event name when creating a group of events") > Signed-off-by: Sven Schnelle Acked-by: Steven Rostedt (Google) -- Steve > --- > .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +- > .../test.d/trigger/inter-event/trigger-synthetic-eprobe.tc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > index db522577ff78..d3a79da215c8 100644 > --- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc > @@ -1,7 +1,7 @@ > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > # description: Generic dynamic event - check if duplicate events are caught > -# requires: dynamic_events "e[:[/]] . []":README > +# requires: dynamic_events "e[:[/][]] . []":README > > echo 0 > events/enable > > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc > index 914fe2e5d030..6461c375694f 100644 > --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc > +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-eprobe.tc > @@ -1,7 +1,7 @@ > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > # description: event trigger - test inter-event histogram trigger eprobe on synthetic event > -# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[/]] . []":README > +# requires: dynamic_events synthetic_events events/syscalls/sys_enter_openat/hist "e[:[/][]] . []":README > > echo 0 > events/enable >