From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07C58C4332F for ; Wed, 12 Oct 2022 17:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbiJLR7W (ORCPT ); Wed, 12 Oct 2022 13:59:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbiJLR7R (ORCPT ); Wed, 12 Oct 2022 13:59:17 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C659FC1CB for ; Wed, 12 Oct 2022 10:59:17 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id g28so17201264pfk.8 for ; Wed, 12 Oct 2022 10:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n+oUQQ+NOkc0QprdtZXS+tTGPaRIPlunaMK86rsYyWQ=; b=JFh6GxxkOz8JaNcKsKjPLyHe1gNpLgVVbwBt4qZ1UYBlhvxvFgWPE4AuXA93vB1nK1 ZPh1Ie1NBwrg37BzebmLRhO1uMB7c0BX2CZT+JvzTvUUrnSB0PtR/iYdsXbx+7mpxt3C q9pFzEvSm+ujLN9icxLCXhaGoHwb3QrGaJW/U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n+oUQQ+NOkc0QprdtZXS+tTGPaRIPlunaMK86rsYyWQ=; b=WF0FVLuyDpjFmr2UJXS1UQtrreBCtscD5eXEJ2OD9Bli6bHI9RtW1Ye3YRTw3Am6qJ 07YK2rhkLQswCeKoyIUFHyvze1ApzvAb+q/JSutilnaaxcFV6wApTrmy4A35ZisUP6sd CIpfT5DVqpWdczaVV/uxgCWHPcsj+8yxBqHSPbcErbWInjeHiqwQTiYaBZhbd1lz+8es MNpA+R7dDwroKV/M7FKIqbe1Nw703/SBpqju3WlwHGbK+cf99UUN2or/so+ROFQKH1/W Z2w7RFpQPyQ4pLqgLt4crRWgYMCFjQ5JfJf8GREWAKUvdatJyKAqFTClBCU90YXcwWWE Zl/w== X-Gm-Message-State: ACrzQf0CuUA3VP/A0d10n010USRXzYJ0mk9DQDdcIpKe6k/vPZPZtOJD ZUkI81UpgJV98HhYf8GjPZzNldwM5pM6Mg== X-Google-Smtp-Source: AMsMyM4xDuOCoIFytmUw7DqbmMWbqve3w8w3bcT5sDaU5p0iV23C0mLCGZRD2rxXASIdG+/jRrZVtw== X-Received: by 2002:a63:188:0:b0:43c:22e9:2d10 with SMTP id 130-20020a630188000000b0043c22e92d10mr26657335pgb.12.1665597555034; Wed, 12 Oct 2022 10:59:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v125-20020a622f83000000b00562ef28aac6sm134384pfv.185.2022.10.12.10.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 10:59:14 -0700 (PDT) Date: Wed, 12 Oct 2022 10:59:13 -0700 From: Kees Cook To: "Guilherme G. Piccoli" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ardb@kernel.org, kernel@gpiccoli.net, anton@enomsg.org, ccross@android.com, Tony Luck , kernel-dev@igalia.com, linux-efi@vger.kernel.org Subject: Re: [PATCH 0/8] Some pstore improvements Message-ID: <202210121059.A173694D06@keescook> References: <20221006224212.569555-1-gpiccoli@igalia.com> <166509868540.1834775.12982405101524535051.b4-ty@chromium.org> <839e44ed-ae89-dfd4-9c38-978ce2693910@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <839e44ed-ae89-dfd4-9c38-978ce2693910@igalia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2022 at 12:50:50PM -0300, Guilherme G. Piccoli wrote: > On 06/10/2022 20:24, Kees Cook wrote: > > On Thu, 6 Oct 2022 19:42:04 -0300, Guilherme G. Piccoli wrote: > >> overall. Most of them are minors, but the implicit conversion thing > >> is a bit more "relevant" in a sense it's more invasive and would fit > >> more as a "fix". > >> > >> The code is based on v6.0, and it was tested with multiple compression > >> algorithms (zstd, deflate, lz4, lzo, 842) and two backends (ramoops and > >> efi_pstore) - I've used a QEMU UEFI guest and Steam Deck for this goal. > >> > >> [...] > > > > Applied to for-next/pstore, thanks! > > > > [1/8] pstore: Improve error reporting in case of backend overlap > > https://git.kernel.org/kees/c/55dbe25ee4c8 > > [2/8] pstore: Expose kmsg_bytes as a module parameter > > https://git.kernel.org/kees/c/1af13c2b6324 > > [3/8] pstore: Inform unregistered backend names as well > > https://git.kernel.org/kees/c/a4f92789f799 > > > > Thanks Kees! just a heads-up on how I'll proceed. > > (a) Patches 1-3 were added already. > > (b) MAINTAINERS patch was reworked by yourself in the other series, so > I'll discard my version. > > (c) I'll rework patches 4 and 8 and re-submit them plus patch 7 > (including the ACK from Ard). > > (d) Gonna discard for now patch 5, planning to test a new version on top > of the crypto acomp interface V2 from Ard/you. Sounds good; thanks! -- Kees Cook