mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Linus Walleij <linus.walleij@linaro.org>, <linux-gpio@vger.kernel.org>
Cc: Mark Pearson <mpearson@lenovo.com>,
	Natikar Basavaraj <Basavaraj.Natikar@amd.com>,
	Pananchikkal Renjith <Renjith.Pananchikkal@amd.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 0/1] Improved debugging for active GPIO causing wakeup
Date: Wed, 12 Oct 2022 17:10:27 -0500	[thread overview]
Message-ID: <20221012221028.4817-1-mario.limonciello@amd.com> (raw)

Some laptops have been reported to wake up from s2idle when plugging
in the AC adapter or by closing the lid.  This series adds support
to better debug what is going on.

With this patch in place we can see that this laptop woke up from
the following GPIO (which on this design happens to also be mirrored
to GPE0xe):

amd_gpio AMDI0030:00: GPIO 18 is active: 0x30057a00

The use of this particular GPIO is OEM design specific.

Knowing these details, it's possible to workaround this problem with
the following on the kernel command line using the parameter for
gpiolib_acpi introduced in commit 6b6af7bd5718f ("gpiolib: acpi:
Add support to ignore programming an interrupt")

acpi_mask_gpe=0x0e gpiolib_acpi.ignore_interrupt=AMDI0030:00@18

Mario Limonciello (1):
  pinctrl: amd: Add dynamic debugging for active GPIOs

 drivers/pinctrl/pinctrl-amd.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-10-12 22:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 22:10 Mario Limonciello [this message]
2022-10-12 22:10 ` [PATCH 1/1] pinctrl: amd: Add dynamic debugging for active GPIOs Mario Limonciello
2022-10-13  6:38   ` Basavaraj Natikar
2022-10-13 13:45   ` Kai-Heng Feng
     [not found]     ` <TYZPR03MB59942B6A03B43132DADF1C5CBD259@TYZPR03MB5994.apcprd03.prod.outlook.com>
2022-10-13 13:53       ` Fw: [External] " Mark Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221012221028.4817-1-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Renjith.Pananchikkal@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®