From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDE39C4332F for ; Thu, 13 Oct 2022 00:35:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231888AbiJMAdd (ORCPT ); Wed, 12 Oct 2022 20:33:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbiJMA3s (ORCPT ); Wed, 12 Oct 2022 20:29:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 666A7DBE56; Wed, 12 Oct 2022 17:27:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64EA0616EA; Thu, 13 Oct 2022 00:24:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07DB5C433C1; Thu, 13 Oct 2022 00:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665620664; bh=MWWlvoIxYq3cLnXWGZXs/MB8JAZXLhih8N0NFWNeK90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jpf217HqQiqJBeZbyGHRX5Wr3Ch9MeJLzzW9vPNYpDWOP6gw/y8yjiT23tjiGH1Va XRJYVEemFdy1asdKj85Pyuhpva3Kz6BdH6BOVNdvvXp3fuI+Rllfb3A3gAuSCaKvQb +opM4265nNsN1hJjiPJLlX6ppKtuQsZJ5LrnqyNDkGwJqK6O8M53God39MCMt0A62i e/5ngaL3ioY8EjNm84r3U2uXc7UeXQfxoXaU71zol0HrVeqI1DR/GZ6xiqyKiABm9A 2nNXHLqX9Bahpgm7wqfZk/tGZYJRxk/oEkR6jvHsQeXfhjgX7OfNVw/OQGdgrRnmVr LrvRfqTEo+P/g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jianglei Nie , Sebastian Reichel , Sasha Levin , sre@kernel.org, kuba@kernel.org, wangqing@vivo.com Subject: [PATCH AUTOSEL 5.10 20/33] HSI: ssi_protocol: fix potential resource leak in ssip_pn_open() Date: Wed, 12 Oct 2022 20:23:19 -0400 Message-Id: <20221013002334.1894749-20-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221013002334.1894749-1-sashal@kernel.org> References: <20221013002334.1894749-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jianglei Nie [ Upstream commit b28dbcb379e6a7f80262c2732a57681b1ee548ca ] ssip_pn_open() claims the HSI client's port with hsi_claim_port(). When hsi_register_port_event() gets some error and returns a negetive value, the HSI client's port should be released with hsi_release_port(). Fix it by calling hsi_release_port() when hsi_register_port_event() fails. Signed-off-by: Jianglei Nie Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/hsi/clients/ssi_protocol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index 96d0eccca3aa..f202751484aa 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c @@ -931,6 +931,7 @@ static int ssip_pn_open(struct net_device *dev) if (err < 0) { dev_err(&cl->device, "Register HSI port event failed (%d)\n", err); + hsi_release_port(cl); return err; } dev_dbg(&cl->device, "Configuring SSI port\n"); -- 2.35.1