From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66968C4332F for ; Thu, 13 Oct 2022 00:57:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232187AbiJMA5Q (ORCPT ); Wed, 12 Oct 2022 20:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231891AbiJMA4d (ORCPT ); Wed, 12 Oct 2022 20:56:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48C6F1D317; Wed, 12 Oct 2022 17:53:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AAB57616B3; Thu, 13 Oct 2022 00:28:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CB4FC433D6; Thu, 13 Oct 2022 00:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665620894; bh=CN8OwgraF7xATNx4wrL4iC2vvl6irstJ9bFWm9sQR8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ir0HUZ27wow+X4vgcVZEEjgr7Wp1tVmeyyOk+VT2tnj1GC3y8ZgS4oCkooBzIlgqM AZqCLuU2y+zrtDQ2EI36ovxBXJjjK4V2DgH9nTL6I75K25jiIeSM+/qXckl/yFHvyU UsKjHM5l6gWjaAGPT8upKZwVsI0cAKH3A1hFHd6OgTtQR93bWickPvkRN/LU7lvB2I tUh2Boo1OZJuRFwU4pJYGNx92OKYp7gyOnxysaqdA3woSBIXuZBaQ/h6ftsMgVWiKu H9EHAymzsYAU5Ww7gD+OxdRIpbObHjuQ9VNg5RlaPFu52/oOTLONYpax1cY5PbRHIi ndNuOVFGTokdA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jianglei Nie , Sebastian Reichel , Sasha Levin , sre@kernel.org, kuba@kernel.org, wangqing@vivo.com Subject: [PATCH AUTOSEL 4.9 05/10] HSI: ssi_protocol: fix potential resource leak in ssip_pn_open() Date: Wed, 12 Oct 2022 20:27:52 -0400 Message-Id: <20221013002802.1896096-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221013002802.1896096-1-sashal@kernel.org> References: <20221013002802.1896096-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jianglei Nie [ Upstream commit b28dbcb379e6a7f80262c2732a57681b1ee548ca ] ssip_pn_open() claims the HSI client's port with hsi_claim_port(). When hsi_register_port_event() gets some error and returns a negetive value, the HSI client's port should be released with hsi_release_port(). Fix it by calling hsi_release_port() when hsi_register_port_event() fails. Signed-off-by: Jianglei Nie Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/hsi/clients/ssi_protocol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index 802afc98e8bd..09e6be746d1e 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c @@ -932,6 +932,7 @@ static int ssip_pn_open(struct net_device *dev) if (err < 0) { dev_err(&cl->device, "Register HSI port event failed (%d)\n", err); + hsi_release_port(cl); return err; } dev_dbg(&cl->device, "Configuring SSI port\n"); -- 2.35.1