From: Li kunyu <kunyu@nfschina.com>
To: damien.lemoal@opensource.wdc.com
Cc: jejb@linux.vnet.ibm.com, kunyu@nfschina.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com
Subject: Re: [PATCH 4.19] scsi: sd: Fix 'sdkp' in sd_first_printk
Date: Thu, 13 Oct 2022 12:49:26 +0800 [thread overview]
Message-ID: <20221013044927.278854-1-kunyu@nfschina.com> (raw)
In-Reply-To: <0e67aa4d-f66e-f392-5950-31b1c90c287b@opensource.wdc.com>
This is defined in the 4.19 kernel:
#define sd_printk(prefix, sdsk, fmt, a...) \
(sdsk)->disk ? \
sdev_prefix_printk(prefix, (sdsk)->device, \
(sdsk)->disk->disk_name, fmt, ##a) : \
sdev_printk(prefix, (sdsk)->device, fmt, ##a)
#define sd_first_printk(prefix, sdsk, fmt, a...) \
do { \
if ((sdkp)->first_scan) \
sd_printk(prefix, sdsk, fmt, ##a); \
} while (0)
Most of the sdsk used in the macro definition has only one sdkp.
This is defined in the v6.0-rc7 kernel:
#define sd_printk(prefix, sdsk, fmt, a...) \
(sdsk)->disk ? \
sdev_prefix_printk(prefix, (sdsk)->device, \
(sdsk)->disk->disk_name, fmt, ##a) : \
sdev_printk(prefix, (sdsk)->device, fmt, ##a)
#define sd_first_printk(prefix, sdsk, fmt, a...) \
do { \
if ((sdsk)->first_scan) \
sd_printk(prefix, sdsk, fmt, ##a); \
} while (0)
Use sdsk in macro definition.
I did report an error when compiling sd. o in the 4.19 kernel. It was modified to say that no more errors were reported in sdsk. Can I continue the 6.0-rc7 writing method here.
next prev parent reply other threads:[~2022-10-13 4:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 2:34 Li kunyu
2022-10-13 3:54 ` Damien Le Moal
2022-10-13 4:49 ` Li kunyu [this message]
2022-10-13 6:26 ` Jason Yan
2022-10-13 6:39 ` Damien Le Moal
2022-10-13 7:02 ` Jason Yan
2022-10-13 7:14 ` Damien Le Moal
2022-10-13 7:39 ` Li kunyu
2022-10-13 7:52 ` Damien Le Moal
2022-10-13 8:37 ` Li kunyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221013044927.278854-1-kunyu@nfschina.com \
--to=kunyu@nfschina.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®